Skip to content

feat: initialize Rslib built-in plugin#10735

Merged
JSerFeng merged 1 commit intomainfrom
ww/rslib-plugin
Jun 24, 2025
Merged

feat: initialize Rslib built-in plugin#10735
JSerFeng merged 1 commit intomainfrom
ww/rslib-plugin

Conversation

@fi3ework
Copy link
Copy Markdown
Member

Summary

Initialize Rslib built-in plugin, to fix #10607 as of now.

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 19, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 5252cd5
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/685a4bb84b7edb00083a9d82

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 19, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 19, 2025

CodSpeed Performance Report

Merging #10735 will not alter performance

Comparing ww/rslib-plugin (5252cd5) with main (781e5b5)

Summary

✅ 16 untouched benchmarks

@fi3ework fi3ework requested a review from JSerFeng June 19, 2025 15:30
@JSerFeng
Copy link
Copy Markdown
Contributor

Should we implement this based on ModernModuleLibraryPlugin instead 🤔

@fi3ework
Copy link
Copy Markdown
Member Author

Should we implement this based on ModernModuleLibraryPlugin instead 🤔

But modern-module will only works with ESM format, require.cache is a CJS method, IMO, it will mostly used in CJS format.

@fi3ework fi3ework force-pushed the ww/rslib-plugin branch 2 times, most recently from df8b4ee to 496ea28 Compare June 23, 2025 03:59
@fi3ework
Copy link
Copy Markdown
Member Author

Moved Rslib plugin to experiments field to prevent from used by others.

@JSerFeng JSerFeng merged commit 953438b into main Jun 24, 2025
38 checks passed
@JSerFeng JSerFeng deleted the ww/rslib-plugin branch June 24, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Generated wrong esm asset

2 participants