Skip to content

perf: introduce ModuleGraphCache and cache the result of get_mode and determine_export_assignments#10584

Merged
LingyuCoder merged 18 commits intoweb-infra-dev:mainfrom
CPunisher:06-04-perf/cache-get-mode
Jun 12, 2025
Merged

perf: introduce ModuleGraphCache and cache the result of get_mode and determine_export_assignments#10584
LingyuCoder merged 18 commits intoweb-infra-dev:mainfrom
CPunisher:06-04-perf/cache-get-mode

Conversation

@CPunisher
Copy link
Copy Markdown
Contributor

@CPunisher CPunisher commented Jun 5, 2025 •
edited
Loading

Summary

Related: web-infra-dev/rslib#1011

In my M3Pro:

Benchmark: Default Before After
rslib 993ms 260ms
unbuild - 639ms
tsup - 71ms
tsdown - 41ms

Most changed files are due to the trait method signature changes and passing module_graph_cache, you may only need to focus on the following files:

  • crates/rspack_core/src/compiler/compilation.rs
  • crates/rspack_core/src/artifacts/module_graph_cache_artifact.rs
  • crates/rspack_plugin_javascript/src/dependency/esm/esm_export_imported_specifier_dependency.rs
  • ... search freeze()

Compare with Webpack

  1. Webpack cache the results of getMode with dependencyCacheProvide(https://github.com/webpack/webpack/blob/19ca74127f7668aaf60d59f4af8fcaee7924541a/lib/ModuleGraph.js#L829). But it seems that rspack doesn't port the moduleMemCache. I'm not sure this is a further optimization or a fallback for correctness.
  2. Keys for caching DetermineExportAssginments are different, see the comments https://github.com/web-infra-dev/rspack/pull/10584/files#diff-24cb30e171ddb52a6fa8ee0070a832ad5164167b770ffd8c3b8def27cd3becd2R112

To validate the cache effectiveness, I collect the cache stats:

total unfreezed cache miss cache hit
GetMode - Rspack 12000 2000 4000 6000
GetMode - Webpack 14000 2000 6000 6000
DetermineExportAssignments - Rspack 6993 1998 4 4991
DetermineExportAssignments - Webpack 6993 1998 4 4991

Not sure why webpack execute GetMode for 2000 times more than rspack

Further

There are still improvements to do, but I'd like to finish them in separated prs

  1. Incremental cache. Currently both webpack and rspack invalidate all the module graph cache when necessary. But I believe some cache is reusable.
  2. Optimize ExportsMode. From my observation ExportsMode can split to variants to reduce the struct size, thus making it cheaper to clone from the cache.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 5, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eadc307
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/684a4b1e6e24c300085f6c05
😎 Deploy Preview https://deploy-preview-10584--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the release: performance release: performance related release(mr only) label Jun 5, 2025
@github-actions

This comment was marked as outdated.

Sign in to view
@CPunisher CPunisher force-pushed the 06-04-perf/cache-get-mode branch from 5ac555b to f075ac8 Compare June 9, 2025 02:27
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10584 will not alter performance

Comparing CPunisher:06-04-perf/cache-get-mode (eadc307) with main (0cec0b6)

Summary

✅ 12 untouched benchmarks

@CPunisher CPunisher force-pushed the 06-04-perf/cache-get-mode branch 2 times, most recently from ab3aab4 to b879b9d Compare June 9, 2025 07:20
@CPunisher CPunisher marked this pull request as ready for review June 9, 2025 07:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 9, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-06-09 15abf21) Current Change
10000_big_production-mode_disable-minimize + exec 35.4 s ± 786 ms 35.4 s ± 216 ms +0.03 %
10000_development-mode + exec 1.87 s ± 28 ms 1.81 s ± 17 ms -3.41 %
10000_development-mode_hmr + exec 755 ms ± 26 ms 754 ms ± 27 ms -0.13 %
10000_production-mode + exec 2.27 s ± 25 ms 2.25 s ± 17 ms -1.28 %
10000_production-mode_persistent-cold + exec 2.45 s ± 33 ms 2.42 s ± 138 ms -1.29 %
10000_production-mode_persistent-hot + exec 1.73 s ± 47 ms 1.7 s ± 27 ms -2.17 %
arco-pro_development-mode + exec 1.82 s ± 98 ms 1.8 s ± 151 ms -0.79 %
arco-pro_development-mode_hmr + exec 385 ms ± 1.2 ms 385 ms ± 0.71 ms -0.14 %
arco-pro_production-mode + exec 3.38 s ± 93 ms 3.36 s ± 316 ms -0.64 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.48 s ± 110 ms 3.4 s ± 52 ms -2.07 %
arco-pro_production-mode_persistent-cold + exec 3.52 s ± 226 ms 3.38 s ± 94 ms -4.00 %
arco-pro_production-mode_persistent-hot + exec 2.06 s ± 86 ms 2.02 s ± 26 ms -1.67 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.43 s ± 110 ms 3.39 s ± 108 ms -1.27 %
large-dyn-imports_development-mode + exec 2.11 s ± 41 ms 2.07 s ± 139 ms -2.23 %
large-dyn-imports_production-mode + exec 2.09 s ± 40 ms 2.06 s ± 43 ms -1.30 %
threejs_development-mode_10x + exec 1.5 s ± 97 ms 1.46 s ± 32 ms -2.43 %
threejs_development-mode_10x_hmr + exec 860 ms ± 22 ms 848 ms ± 9.1 ms -1.33 %
threejs_production-mode_10x + exec 4.8 s ± 91 ms 4.84 s ± 248 ms +0.95 %
threejs_production-mode_10x_persistent-cold + exec 4.9 s ± 57 ms 4.95 s ± 294 ms +1.09 %
threejs_production-mode_10x_persistent-hot + exec 4.26 s ± 96 ms 4.26 s ± 259 ms -0.04 %
10000_big_production-mode_disable-minimize + rss memory 9548 MiB ± 746 MiB 9147 MiB ± 51.6 MiB -4.21 %
10000_development-mode + rss memory 653 MiB ± 23.9 MiB 693 MiB ± 55 MiB +6.17 %
10000_development-mode_hmr + rss memory 794 MiB ± 13.2 MiB 807 MiB ± 34.4 MiB +1.58 %
10000_production-mode + rss memory 664 MiB ± 43.2 MiB 700 MiB ± 34.7 MiB +5.43 %
10000_production-mode_persistent-cold + rss memory 760 MiB ± 52.7 MiB 816 MiB ± 37.3 MiB +7.42 %
10000_production-mode_persistent-hot + rss memory 781 MiB ± 19.2 MiB 773 MiB ± 37.3 MiB -1.08 %
arco-pro_development-mode + rss memory 576 MiB ± 58.4 MiB 591 MiB ± 43.4 MiB +2.64 %
arco-pro_development-mode_hmr + rss memory 494 MiB ± 44.3 MiB 519 MiB ± 43.4 MiB +5.03 %
arco-pro_production-mode + rss memory 695 MiB ± 40.7 MiB 725 MiB ± 93.9 MiB +4.35 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 698 MiB ± 60.3 MiB 706 MiB ± 77.6 MiB +1.21 %
arco-pro_production-mode_persistent-cold + rss memory 777 MiB ± 138 MiB 821 MiB ± 76.4 MiB +5.70 %
arco-pro_production-mode_persistent-hot + rss memory 664 MiB ± 74.7 MiB 670 MiB ± 50 MiB +0.87 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 697 MiB ± 90.5 MiB 700 MiB ± 69.2 MiB +0.47 %
large-dyn-imports_development-mode + rss memory 661 MiB ± 6.44 MiB 687 MiB ± 14.9 MiB +3.88 %
large-dyn-imports_production-mode + rss memory 555 MiB ± 8.09 MiB 579 MiB ± 13.3 MiB +4.44 %
threejs_development-mode_10x + rss memory 624 MiB ± 9.86 MiB 656 MiB ± 18.4 MiB +5.08 %
threejs_development-mode_10x_hmr + rss memory 815 MiB ± 25.4 MiB 846 MiB ± 24.8 MiB +3.84 %
threejs_production-mode_10x + rss memory 878 MiB ± 32.1 MiB 927 MiB ± 27.1 MiB +5.56 %
threejs_production-mode_10x_persistent-cold + rss memory 992 MiB ± 27.4 MiB 1014 MiB ± 49.4 MiB +2.28 %
threejs_production-mode_10x_persistent-hot + rss memory 837 MiB ± 42.5 MiB 842 MiB ± 52.6 MiB +0.59 %

@CPunisher CPunisher force-pushed the 06-04-perf/cache-get-mode branch from 91c0fc2 to eadc307 Compare June 12, 2025 03:35
@LingyuCoder LingyuCoder requested a review from JSerFeng June 12, 2025 08:13
LingyuCoder
LingyuCoder approved these changes Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LingyuCoder
Copy link
Copy Markdown
Contributor

LingyuCoder commented Jun 12, 2025

cc @jerrykingxyz @JSerFeng

@LingyuCoder LingyuCoder merged commit 95b9225 into web-infra-dev:main Jun 12, 2025
34 checks passed
@CPunisher CPunisher mentioned this pull request Jun 13, 2025
Merged
2 tasks
@CPunisher CPunisher deleted the 06-04-perf/cache-get-mode branch June 13, 2025 02:31
@CPunisher CPunisher mentioned this pull request Jun 16, 2025
Merged
@Timeless0911 Timeless0911 mentioned this pull request Jun 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LingyuCoder LingyuCoder LingyuCoder approved these changes

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

@hardfist hardfist Awaiting requested review from hardfist

@JSerFeng JSerFeng Awaiting requested review from JSerFeng

Assignees

No one assigned

Labels

release: performance release: performance related release(mr only)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CPunisher @LingyuCoder @jerrykingxyz