feat: compilation.addEntry support#10268
Merged
SyMind merged 2 commits intoweb-infra-dev:mainfrom May 9, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
3536fde to
977fcc2
Compare
CodSpeed Performance ReportMerging #10268 will not alter performanceComparing 🎉 Hooray!
|
SyMind
approved these changes
May 9, 2025
|
@henryqdineen 你好，我想问一下 其实这里的 compilation.addEntry 算不算 ompilation.addInclude 的别名？ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In our webpack-based internal framework we use
compilation.addEntry()to conditionally add entry points based on configuration and some file system conventions. I am aware that dynamic entrypoints exist but we have found thatcompilation.addEntry()to be more powerful and allow better encapsulation using plugins. I saw thatcompilation.addInclude()was implemented and it seemed likeaddEntry()could also be.This PR adds support for the
compilation.addEntry()entry and is mostly based off of the existingaddInclude()implementation. They could probably share more code but I'm not sure if that is wanted.Thanks!
Checklist
configCases/compilation/add-entrytest