✅ Deploy Preview for rspack canceled.

CodSpeed Performance Report

Merging #10246 will not alter performance

_{Comparing CPunisher:04-29-feat/wasm-tracing (8258e44) with main (972c005)}

Summary

✅ 11 untouched benchmarks

cleanup function is called by exit-hook and sends an flush message to the tracing thread. This means cleanup function is called when there's no active handlers (workers) running, which means the chrome tracing thread is not running. So we may choose another way to call cleanup.

I'm confused of what kind of problem you're resolving. What is wasm tracing cleanup related to? Does it mean that cleanup function should be invoked before workers are destroyed?

EDIT: I checked out the tracing_chrome code, it uses an separate thread to write buffers into files. Do you mean to find a way to write tracing into trace file before it was destroyed? I think we are on the same page now. If that is the case, is it possible for you to leverage rspack.experiments.globalTrace.cleanup to eagerly flush the tracer?

If that is the case, is it possible for you to leverage rspack.experiments.globalTrace.cleanup to eagerly flush the tracer?

I think so. Just now I realize that cleanupGlobalTrace actually flushes the writer rather than shutdowns everything. So we can call it anywhere.

Thanks!