fix: dead loop of circular dependency plugin#10212
Merged
fireairforce merged 3 commits intomainfrom Apr 27, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a dead loop issue in the circular dependency plugin by revising how dependency relations are tracked.
- Replaces IdentifierSet with rustc_hash::FxHashSet for tracking dependency relations.
- Introduces an edge-check with seen_relations in the recursive dependency traversal.
- Updates Cargo.toml to include the rustc-hash dependency.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/rspack_plugin_circular_dependencies/src/lib.rs | Refactored cyclical dependency detection by replacing IdentifierSet with a HashSet and adding edge-based filtering in the recursion. |
| crates/rspack_plugin_circular_dependencies/Cargo.toml | Added dependency for rustc-hash to support the new HashSet usage. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
CodSpeed Performance ReportMerging #10212 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #10208
Checklist