Skip to content

test: should not report on wrong case when error#10185

Merged
LingyuCoder merged 1 commit intomainfrom
test/report-error-on-wrong-case
Apr 25, 2025
Merged

test: should not report on wrong case when error#10185
LingyuCoder merged 1 commit intomainfrom
test/report-error-on-wrong-case

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Apr 25, 2025

Summary

Should add .catch to runner tasks of concurrent test cases. To prevent the error being thrown to unhandledRejection which will be captured by jest and attach to currently running test cases.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested review from Copilot and h-a-n-a April 25, 2025 09:00
Copilot AI reviewed Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the concurrent test runner tasks in order to prevent unhandled promise rejections from interfering with running tests and to improve the error handling mechanism.

  • Refactored the promise and chain handling in the test creator to use .catch for error prevention.
  • Added a null-check for bundles in the basic processor and standardized test descriptions in watch and new-incremental test cases.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/rspack-test-tools/src/test/creator.ts Updated promise handling and error propagation.
packages/rspack-test-tools/src/processor/basic.ts Added bundle null-check to avoid processing errors.
packages/rspack-test-tools/src/case/watch.ts Standardized description string format.
packages/rspack-test-tools/src/case/new-incremental.ts Standardized description string format.

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit f72d54f
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680b4f517aebc90008f98f95
😎 Deploy Preview https://deploy-preview-10185--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LingyuCoder LingyuCoder enabled auto-merge (squash) April 25, 2025 09:03
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 25, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #10185 will not alter performance

Comparing test/report-error-on-wrong-case (f72d54f) with main (769c4a5)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@LingyuCoder LingyuCoder merged commit 1d6edce into main Apr 25, 2025
38 checks passed
@LingyuCoder LingyuCoder deleted the test/report-error-on-wrong-case branch April 25, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@h-a-n-a h-a-n-a h-a-n-a approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LingyuCoder @h-a-n-a