Skip to content

fix: ignore parsing errors on CSS modules from lightningcss-loader#10172

Merged
SyMind merged 2 commits intomainfrom
improve-lightningcss-loader-warning
Apr 25, 2025
Merged

fix: ignore parsing errors on CSS modules from lightningcss-loader#10172
SyMind merged 2 commits intomainfrom
improve-lightningcss-loader-warning

Conversation

@SyMind
Copy link
Member

@SyMind SyMind commented Apr 25, 2025 •
edited
Loading

Summary

  1. ignore parsing errors on CSS modules from lightningcss-loader. CSS modules will be handled by downstream loaders.
  2. improve lightningcss-loader warning message by LightningCSS parse warning prefix.
  3. fix the document for ignore lightningcss-loader warning message.

Fix #10162

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@SyMind SyMind requested a review from JSerFeng as a code owner April 25, 2025 03:30
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 25, 2025
@netlify
Copy link

netlify bot commented Apr 25, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e46fbc5
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680b03495ff71b0008fd70ad

@SyMind SyMind force-pushed the improve-lightningcss-loader-warning branch from 114b67c to e46fbc5 Compare April 25, 2025 03:36
@chenjiahan
Copy link
Member

chenjiahan commented Apr 25, 2025

LGTM 👍

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 25, 2025

CodSpeed Performance Report

Merging #10172 will not alter performance

Comparing improve-lightningcss-loader-warning (e46fbc5) with main (8f38907)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@SyMind SyMind merged commit 830a66b into main Apr 25, 2025
30 checks passed
@SyMind SyMind deleted the improve-lightningcss-loader-warning branch April 25, 2025 04:06
@chenjiahan chenjiahan mentioned this pull request Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@JSerFeng JSerFeng Awaiting requested review from JSerFeng JSerFeng is a code owner

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: V1.3.6 throw warning with css modules :global pseudo

2 participants

@SyMind @chenjiahan