fix: should regenerate runtime chunk hash when using get chunk filename runtime module#10167
Merged
LingyuCoder merged 2 commits intomainfrom Apr 24, 2025
Merged
Conversation
…me runtime module
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the runtime chunk hash regeneration for the GetChunkFilenameRuntimeModule by ensuring that dependent chunk hashes are correctly handled. Key changes include:
- Updating test configurations and cases to verify that runtime chunk filenames include the proper hash values.
- Adding a full_hash method in the runtime module to always return true, simplifying the dependency on fullhash.
- Modifying the module chunk format logic to early-return when the chunk does not have an entry module.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/rspack-test-tools/tests/watchCases/hashes/runtimeChunkGetChunkFilename/test.config.js | Added test cases to verify that generated runtime chunk filenames are included in the output content. |
| packages/rspack-test-tools/tests/watchCases/hashes/runtimeChunkGetChunkFilename/rspack.config.js | Updated configuration to use module chunk format and ensure proper filename patterns. |
| packages/rspack-test-tools/tests/watchCases/hashes/runtimeChunkGetChunkFilename/1/index.js | Added a simple test to output a log for runtime chunk validation. |
| packages/rspack-test-tools/tests/watchCases/hashes/runtimeChunkGetChunkFilename/0/warnings.js | Provided warning message tests related to dependent hash calculation. |
| packages/rspack-test-tools/tests/watchCases/hashes/runtimeChunkGetChunkFilename/0/index2.js | Added a test file to validate behavior when importing dependent hash module. |
| packages/rspack-test-tools/tests/watchCases/hashes/runtimeChunkGetChunkFilename/0/index.js | Included a simple test with a console log to support runtime chunk testing. |
| packages/rspack-test-tools/tests/watchCases/hashes/runtimeChunkGetChunkFilename/0/dependent-hash.js | Integrated a placeholder to mimic webpack behavior using webpack_get_script_filename. |
| crates/rspack_plugin_runtime/src/runtime_module/get_chunk_filename.rs | Introduced a full_hash method to always return true, deviating from webpack’s dependentHash usage. |
| crates/rspack_plugin_runtime/src/module_chunk_format.rs | Refactored the chunk format check to early-return if the chunk lacks an entry module. |
Comments suppressed due to low confidence (1)
crates/rspack_plugin_runtime/src/runtime_module/get_chunk_filename.rs:390
- [nitpick] Consider clarifying the naming of the 'full_hash' method to more explicitly indicate that it always returns true, which differentiates it from webpack's 'dependentHash' behavior.
fn full_hash(&self) -> bool {
ahabhgk
previously approved these changes
Apr 24, 2025
CodSpeed Performance ReportMerging #10167 will not alter performanceComparing 🎉 Hooray!
|
…me runtime module
ahabhgk
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
another case of #9986
The GetChunkFilenameRuntimeModule may include some chunks that change after rebuilding. So this runtime module should depend on their hashes. Changing of their hashes may lead to the change of runtime chunk. And then the generated code of entry which uses
chunkFormat: "module"should also change.In webpack, it uses a
dependentHashflag too handle this. But I think we can just reusefullhashto handle this.Checklist