Skip to content

fix(parallel-loader): should not pass options for which loaders are not set to parallel#10164

Merged
chenjiahan merged 1 commit intomainfrom
fix-unclonable
Apr 24, 2025
Merged

fix(parallel-loader): should not pass options for which loaders are not set to parallel#10164
chenjiahan merged 1 commit intomainfrom
fix-unclonable

Conversation

@h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Apr 24, 2025 •
edited
Loading

Summary

Worker threads would execute loaders until it's not set to parallel or it's a builtin loader that should be yielded to rust.
Previously, loader runner would pass loaders with options into worker thread without checking if the loader enabled parallel. In this PR, only options of which loader is set to parallel are passed.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@h-a-n-a h-a-n-a changed the title fix(parallel-loader): should not pass options for which loaders are n… fix(parallel-loader): should not pass options for which loaders are not set to parallel Apr 24, 2025
@netlify
Copy link

netlify bot commented Apr 24, 2025 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit d1269d1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680a03116968850008986ed2
😎 Deploy Preview https://deploy-preview-10164--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 24, 2025
chenjiahan
chenjiahan approved these changes Apr 24, 2025
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenjiahan chenjiahan enabled auto-merge (squash) April 24, 2025 09:27
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Performance Report

Merging #10164 will not alter performance

Comparing fix-unclonable (d1269d1) with main (f5e46dc)

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan merged commit 184982e into main Apr 24, 2025
40 checks passed
@chenjiahan chenjiahan deleted the fix-unclonable branch April 24, 2025 09:46
@chenjiahan chenjiahan mentioned this pull request Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h-a-n-a @chenjiahan