fix: circularDependencyRspackPlugin should check all cycle#10163
Merged
LingyuCoder merged 2 commits intomainfrom Apr 24, 2025
Merged
fix: circularDependencyRspackPlugin should check all cycle#10163LingyuCoder merged 2 commits intomainfrom
LingyuCoder merged 2 commits intomainfrom
Conversation
✅ Deploy Preview for rspack canceled.
|
ee79641 to
d4867b8
Compare
LingyuCoder
previously approved these changes
Apr 24, 2025
CodSpeed Performance ReportMerging #10163 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
CircularDependencyRspackPlugin, we should check all cycle, for example, if we have follow case:In that case, we shoud output two cycle check diagnostic messages:
In the algorithm of
CircularDependencyRspackPlugin'sfn recurse_dependencies()we just use avisited(seen_set) hashmap to filter the duplicate module id, likec.jswill be recurse twice, so it will not be outputed twice, the output now will be:The behavior is not right as the user's feedback, so we need to move the
visitedhashmap here in the algorithm, just use the simple algorithm here like the answer of https://leetcode.cn/problems/binary-tree-paths/description/.closes: #9889
Checklist