fix: support license plugin when enable concatenated#10158
Merged
LingyuCoder merged 2 commits intomainfrom Apr 24, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the issue with the license plugin by adding support for concatenated modules and introducing a new getter for the parent module in dependencies.
- Added a new getter "root_module" for ConcatenatedModule to obtain the root module.
- Introduced a new getter "_parentModule" in Dependency to facilitate access to a dependency’s parent module.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/node_binding/src/modules/concatenated_module.rs | Added the "root_module" getter to retrieve the module that serves as the root for concatenated modules. |
| crates/node_binding/src/dependency.rs | Added the "_parentModule" getter to expose parent module information from the dependency. |
CodSpeed Performance ReportMerging #10158 will not alter performanceComparing Summary
|
JSerFeng
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #8924
Dependency._parentModuleConcatenatedModule.rootModuleChecklist