fix: call compiler.close when having errors#10154
Merged
LingyuCoder merged 1 commit intomainfrom Apr 24, 2025
Merged
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where persistent caches may become invalid by ensuring that compiler.close is always called, even when errors occur during compilation.
- Always call compiler.close irrespective of compilation errors.
- Remove conditional logic that bypassed compiler.close when errors were present.
Comments suppressed due to low confidence (1)
packages/rspack-cli/src/commands/build.ts:125
- When closeErr is present, the errorHandler is still called with the original error and stats. Consider propagating or handling closeErr explicitly to avoid ambiguity between close errors and compilation errors.
compiler.close(closeErr => {
CodSpeed Performance ReportMerging #10154 will not alter performanceComparing Summary
|
compiler.close when having errorscompiler.close when having errors
This was referenced Apr 24, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #9699
Persistent cache of rspack is implemented in Rust and should always call
compiler.closeafter building.Checklist