Skip to content

refactor(incremental): disable passes only for current rebuild#10145

Merged
ahabhgk merged 6 commits intomainfrom
refactor-inc-disable-pass
Apr 25, 2025
Merged

refactor(incremental): disable passes only for current rebuild#10145
ahabhgk merged 6 commits intomainfrom
refactor-inc-disable-pass

Conversation

@ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Apr 23, 2025

Summary

  • only disable incremental for the current compilation, if next compilation we are able to incremental, we will still run in incremental
  • incremental only affect rebuild, won't affect build, this PR ensure that on code (hot start will run as rebuild)
  • can_read/write_mutations => mutations_readable/writeable, use passes_enabled() to see whether it's enabled by user's options

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@ahabhgk ahabhgk requested a review from jerrykingxyz as a code owner April 23, 2025 13:23
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 23, 2025
@netlify
Copy link

netlify bot commented Apr 23, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit e070947
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/680a2a78e32f3b0008cbbba2

@ahabhgk ahabhgk changed the title refactor(incremental): disable passes only for each rebuild compilation refactor(incremental): disable passes only for current rebuild Apr 24, 2025
@ahabhgk ahabhgk requested a review from JSerFeng April 24, 2025 08:58
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Performance Report

Merging #10145 will not alter performance

Comparing refactor-inc-disable-pass (e070947) with main (73d6011)

Summary

✅ 11 untouched benchmarks

@ahabhgk ahabhgk force-pushed the refactor-inc-disable-pass branch from 2c1a7f9 to 1e20a79 Compare April 24, 2025 11:41
@ahabhgk ahabhgk enabled auto-merge (squash) April 24, 2025 13:21
@ahabhgk ahabhgk merged commit aee14f8 into main Apr 25, 2025
30 checks passed
@ahabhgk ahabhgk deleted the refactor-inc-disable-pass branch April 25, 2025 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants