fix: multiple runtime keys broke filename in runtime module#10144
Merged
LingyuCoder merged 3 commits intomainfrom Apr 24, 2025
Merged
fix: multiple runtime keys broke filename in runtime module#10144LingyuCoder merged 3 commits intomainfrom
LingyuCoder merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue where filenames were broken due to multiple runtime keys being joined with newline characters.
- Updated the runtime key concatenation delimiter from a newline to an underscore.
Comments suppressed due to low confidence (1)
crates/rspack_core/src/runtime.rs:132
- Changing the join delimiter from a newline to an underscore fixes the filename breakage issue. Verify that no downstream dependencies rely on the newline delimiter to avoid unexpected side effects.
self.key = ordered.join("_")
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #10144 will not alter performanceComparing Summary
|
ahabhgk
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #9902
If a chunk belongs to runtime which has multiple runtime keys, and the filename template of this chunk has
[runtime]in it, the generated filename will be broken by the\n.Checklist