fix(storage): should flush writer when flushing file mtime#10143
Merged
LingyuCoder merged 1 commit intomainfrom Apr 23, 2025
Merged
fix(storage): should flush writer when flushing file mtime#10143LingyuCoder merged 1 commit intomainfrom
LingyuCoder merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the file not found issue by ensuring the file writer is flushed after writing, thereby updating the file mtime correctly.
- Added a flush call after writing file content.
- Modified writer handling in the flush_file_mtime function.
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #10143 will not alter performanceComparing Summary
|
h-a-n-a
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Should flush the file writer when testing rspack_storage otherwise the files will not be found
Checklist