fix(core): enable tracing for hook by default except in make stage#10141
Merged
fix(core): enable tracing for hook by default except in make stage#10141
Conversation
✅ Deploy Preview for rspack canceled.
|
ahabhgk
previously approved these changes
Apr 23, 2025
CodSpeed Performance ReportMerging #10141 will not alter performanceComparing Summary
|
ahabhgk
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable tracing for all hook(except for hook in make stage) by default, make related hook will be called tons of time for large project which will cause large trace.json and perfeto UI unreadable so it's disabled by default.
Checklist