fix: plugin compilation hooks leak#10137
Merged
quininer merged 1 commit intoweb-infra-dev:mainfrom Apr 23, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
0876c63 to
1df2614
Compare
CodSpeed Performance ReportMerging #10137 will not alter performanceComparing 🎉 Hooray!
|
1df2614 to
4cb74d2
Compare
ahabhgk
approved these changes
Apr 23, 2025
h-a-n-a
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the hooks in plugin's
COMPILATION_HOOKS_MAPwhenclear_cacheto avoid leak memory when rebuild.Strictly speaking this is not semantically correct, since this is not a cache, and it is also hard to track hooks usage. There should be a better management mechanism in future. but for now, this is a simple fix.
Checklist