Skip to content

fix: should rebuild css module when rebuild css extract entry#10124

Merged
LingyuCoder merged 1 commit intomainfrom
fix/css-extract-rebuild-module
Apr 23, 2025
Merged

fix: should rebuild css module when rebuild css extract entry#10124
LingyuCoder merged 1 commit intomainfrom
fix/css-extract-rebuild-module

Conversation

@LingyuCoder
Copy link
Contributor

Summary

fix #9778

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Apr 22, 2025
@netlify
Copy link

netlify bot commented Apr 22, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 412f482
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/68077c53a1438400078b9019

@LingyuCoder LingyuCoder requested a review from JSerFeng April 22, 2025 10:41
@LingyuCoder LingyuCoder force-pushed the fix/css-extract-rebuild-module branch from 777a199 to c07040b Compare April 22, 2025 10:45
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 22, 2025

CodSpeed Performance Report

Merging #10124 will not alter performance

Comparing fix/css-extract-rebuild-module (412f482) with main (200ebe7)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@LingyuCoder LingyuCoder force-pushed the fix/css-extract-rebuild-module branch from c07040b to 412f482 Compare April 22, 2025 11:24
@LingyuCoder LingyuCoder enabled auto-merge (squash) April 23, 2025 06:17
@LingyuCoder LingyuCoder merged commit 242967b into main Apr 23, 2025
30 checks passed
@LingyuCoder LingyuCoder deleted the fix/css-extract-rebuild-module branch April 23, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: rebuildModule not work when using with importModule(i.e.: with CssExtract)

2 participants