fix: should skip rebuilding chunk graph if only specifier order change#10104
Merged
fix: should skip rebuilding chunk graph if only specifier order change#10104
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #10104 will not alter performanceComparing 🎉 Hooray!
|
98a755e to
217d8c5
Compare
ahabhgk
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When there is only orders of specifiers change, chunk graph should not be re-created.
The actual order of the outgoings should be
lib1thenlib2, which means we should use the first outgoing as its order.We should make sure lib1 is always present before lib2. So we should take all connections into account even if it's activeState is not true.
Checklist