Skip to content

fix: storage validate hash with content#10101

Merged
jerrykingxyz merged 2 commits intomainfrom
jerry/hash
Apr 24, 2025
Merged

fix: storage validate hash with content#10101
jerrykingxyz merged 2 commits intomainfrom
jerry/hash

Conversation

@jerrykingxyz
Copy link
Copy Markdown
Contributor

@jerrykingxyz jerrykingxyz commented Apr 21, 2025

Summary

The persistent cache checks whether the saved file is invalid by mtime and size, and it will cause download cache storage invalidate.

This PR will make storage check whether the saved file is invalid by file hash.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@jerrykingxyz jerrykingxyz changed the title fix: storage validate with content fix: storage validate hash with content Apr 21, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 21, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 24dc15e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6809aef5ff0a020008b2b453

@jerrykingxyz jerrykingxyz linked an issue Apr 21, 2025 that may be closed by this pull request
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Apr 21, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 21, 2025

CodSpeed Performance Report

Merging #10101 will not alter performance

Comparing jerry/hash (24dc15e) with main (ef69e07)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@jerrykingxyz jerrykingxyz merged commit be5dd1d into main Apr 24, 2025
32 checks passed
@jerrykingxyz jerrykingxyz deleted the jerry/hash branch April 24, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cache timestamp changes lead to invalidation?

2 participants