Skip to content

fix(cli): simplify RSPACK_PROFILE#10072

Merged
hardfist merged 2 commits intomainfrom
yj/simplify-rspack-profile
Apr 21, 2025
Merged

fix(cli): simplify RSPACK_PROFILE#10072
hardfist merged 2 commits intomainfrom
yj/simplify-rspack-profile

Conversation

@hardfist
Copy link
Copy Markdown
Contributor

@hardfist hardfist commented Apr 17, 2025

Summary

The current RSPACK_PROFILE syntax is too complex to understand(RSPACK_PROFILE='TRACE=filter=trace&output=./rspack.trace&layer=chrome) cause

  • it supports JSCPU | LOGGING | TRACE at same time
  • it supports trace layer trace output trace filter at same time
  • trace filter itself is already very complex

so this pr try to simplify the RSPACK_PROFILE logic

since RSPACK_PROFILE is a debugging tools which should not be treated as public api, so this change is not treated as breaking change.

Follow up

  • rewriting tracing section

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 17, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 12d83b1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/68022c9470b94000086e24c3

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Apr 17, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 17, 2025

CodSpeed Performance Report

Merging #10072 will not alter performance

Comparing yj/simplify-rspack-profile (12d83b1) with main (fc8d351)

Summary

✅ 11 untouched benchmarks

@hardfist hardfist force-pushed the yj/simplify-rspack-profile branch from 170e2f1 to bad96c2 Compare April 18, 2025 10:41
@hardfist hardfist marked this pull request as ready for review April 18, 2025 10:42
@hardfist hardfist force-pushed the yj/simplify-rspack-profile branch from bad96c2 to 12d83b1 Compare April 18, 2025 10:42
@hardfist hardfist enabled auto-merge (squash) April 18, 2025 16:44
@hardfist hardfist merged commit 9664a09 into main Apr 21, 2025
27 checks passed
@hardfist hardfist deleted the yj/simplify-rspack-profile branch April 21, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants