fix: import module entry dependency resolve options#10070
Merged
LingyuCoder merged 3 commits intomainfrom Apr 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tests/webpack-test/configCases/concatenate-modules/import-module/test.filter.js:1
- The removal of this test filter file may reduce test coverage for the import module dependency handling. Please ensure that alternative tests are in place to validate the new resolve option for 'loaderImport'.
-module.exports = () => {
✅ Deploy Preview for rspack canceled.
|
CodSpeed Performance ReportMerging #10070 will not alter performanceComparing Summary
|
JSerFeng
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix #8447
The import module entry dependency's category is
loaderImport, and it is missed in by depenedency of default resolve options. This make the resolve options inconsistent with other modules.Checklist