Skip to content

feat: support svg-chunk-webpack-plugin#10066

Merged
LingyuCoder merged 2 commits intomainfrom
feat/support-svg-chunk-webpack-plugin
Apr 17, 2025
Merged

feat: support svg-chunk-webpack-plugin#10066
LingyuCoder merged 2 commits intomainfrom
feat/support-svg-chunk-webpack-plugin

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Apr 17, 2025 •
edited
Loading

Summary

close #5766

  • support setter of loaderContext.module.factoryMeta
  • support readableIdentifier of Module
  • support chunkGraph.getOrderedChunkModulesIterable()

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from Copilot April 17, 2025 07:43
@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: feature release: feature related release(mr only) labels Apr 17, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 17, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 32eb835
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6800cb866a99120008fd4c7a

Copilot AI reviewed Apr 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

crates/node_binding/src/modules/macros.rs:151

  • [nitpick] The property '_readableIdentifier' in the node binding appears inconsistent with the naming in other modules (which use 'readableIdentifier'). Consider aligning the property name for clarity.
napi::Property::new("_readableIdentifier")?.with_getter(readable_identifier_getter),

crates/node_binding/src/module.rs:153

  • [nitpick] The property '_readableIdentifier' appears with an underscore, which may be inconsistent with external API naming conventions. Consider renaming it to 'readableIdentifier' to maintain consistency.
Property::new("_readableIdentifier")?.with_getter(readable_identifier_getter),

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 17, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10066 will not alter performance

Comparing feat/support-svg-chunk-webpack-plugin (32eb835) with main (688a3d5)

Summary

✅ 11 untouched benchmarks

@LingyuCoder LingyuCoder enabled auto-merge (squash) April 17, 2025 08:16
GiveMe-A-Name
GiveMe-A-Name previously approved these changes Apr 17, 2025
View reviewed changes
@GiveMe-A-Name
Copy link
Copy Markdown
Member

GiveMe-A-Name commented Apr 17, 2025

You need resolve conflict.

@LingyuCoder LingyuCoder force-pushed the feat/support-svg-chunk-webpack-plugin branch from fd22daa to 32eb835 Compare April 17, 2025 09:36
@LingyuCoder LingyuCoder merged commit ed72c93 into main Apr 17, 2025
27 checks passed
@LingyuCoder LingyuCoder deleted the feat/support-svg-chunk-webpack-plugin branch April 17, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@GiveMe-A-Name GiveMe-A-Name GiveMe-A-Name approved these changes

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: support svg-chunk-webpack-plugin

3 participants

@LingyuCoder @GiveMe-A-Name