perf(hash): avoid heap allocations in hash#10060
Merged
ahabhgk merged 1 commit intoweb-infra-dev:mainfrom Apr 17, 2025
Merged
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
290aa5c to
703bcc2
Compare
CodSpeed Performance ReportMerging #10060 will not alter performanceComparing Summary
|
a09a0e1 to
ff201da
Compare
ff201da to
bb92f54
Compare
ahabhgk
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are currently 3 unnecessary heap allocations in hash. This PR will remove as many of them as possible.
Since
md4output is larger thansmol_strcapacity, a heap allocation still occurs when usingmd4. We usexxhashby default, so no further optimization is done here.data-encodingis suitable for size-sensitive scenarios, but because it shares an impl with encodings such as base64, it is not usually inlined. here we replace it with our own simple impl.Checklist