Skip to content

fix: dev server types#10038

Merged
chenjiahan merged 3 commits intomainfrom
fix/dev-server-types
Apr 16, 2025
Merged

fix: dev server types#10038
chenjiahan merged 3 commits intomainfrom
fix/dev-server-types

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Apr 15, 2025

Summary

fix #9077

Use the built-in types on DevServer instead of inheriting from webpack-dev-server.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 15, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 1d054da
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67ff17a0beaa67000931911c

@LingyuCoder LingyuCoder requested a review from chenjiahan as a code owner April 15, 2025 12:07
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 15, 2025

CodSpeed Performance Report

Merging #10038 will not alter performance

Comparing fix/dev-server-types (1d054da) with main (4bb7680)

Summary

✅ 11 untouched benchmarks

chenjiahan
chenjiahan previously approved these changes Apr 15, 2025
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be better if we could add JSDoc for these devServer options in the future.

@chenjiahan chenjiahan enabled auto-merge (squash) April 16, 2025 02:45
@chenjiahan chenjiahan merged commit a2b6911 into main Apr 16, 2025
27 checks passed
@chenjiahan chenjiahan deleted the fix/dev-server-types branch April 16, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: webpack-dev-server should be a dependency not a devDependency

2 participants