Skip to content

fix: should rename __webpack_require__ pat in parameters#10036

Merged
Timeless0911 merged 1 commit intomainfrom
fix/compat-webpack-plugin
Apr 15, 2025
Merged

fix: should rename __webpack_require__ pat in parameters#10036
Timeless0911 merged 1 commit intomainfrom
fix/compat-webpack-plugin

Conversation

@JSerFeng
Copy link
Copy Markdown
Contributor

Summary

const __webpack_require__ = 1;
call({ __webpack_require__ })

After

const __webpack_require_rename__ = 1;
call({ __webpack_require__: __webpack_require_rename__ })

The parameter is not visited by pattern hook, instead, it uses identifier hook, so we should also rename it in identifier hook

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: bug fix release: bug related release(mr only) label Apr 15, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit bcd5ec4
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67fe414a826a110007d9009b
😎 Deploy Preview https://deploy-preview-10036--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 15, 2025
@JSerFeng JSerFeng requested a review from Timeless0911 April 15, 2025 11:42
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 15, 2025

CodSpeed Performance Report

Merging #10036 will not alter performance

Comparing fix/compat-webpack-plugin (bcd5ec4) with main (ff1c3b7)

Summary

✅ 11 untouched benchmarks

@Timeless0911 Timeless0911 merged commit 66602bd into main Apr 15, 2025
31 checks passed
@Timeless0911 Timeless0911 deleted the fix/compat-webpack-plugin branch April 15, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants