Skip to content

fix(incremental): chunk id change should affect associate chunk#10032

Merged
ahabhgk merged 2 commits intomainfrom
fix-inc-chunk-id-change
Apr 15, 2025
Merged

fix(incremental): chunk id change should affect associate chunk#10032
ahabhgk merged 2 commits intomainfrom
fix-inc-chunk-id-change

Conversation

@ahabhgk
Copy link
Copy Markdown
Contributor

@ahabhgk ahabhgk commented Apr 15, 2025

Summary

If the chunk id changes, the chunk is affected:

pub fn update_hash(&self, hasher: &mut RspackHash, compilation: &Compilation) {
self.id(&compilation.chunk_ids_artifact).hash(hasher);

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 15, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit a257f44
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67fe16b0044eb20008fe98f7

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 15, 2025
@ahabhgk ahabhgk requested review from JSerFeng and SyMind April 15, 2025 07:21
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 15, 2025

CodSpeed Performance Report

Merging #10032 will not alter performance

Comparing fix-inc-chunk-id-change (a257f44) with main (8ecfaf0)

Summary

✅ 11 untouched benchmarks

@ahabhgk ahabhgk enabled auto-merge (squash) April 15, 2025 08:23
@ahabhgk ahabhgk merged commit 2e891fd into main Apr 15, 2025
29 checks passed
@ahabhgk ahabhgk deleted the fix-inc-chunk-id-change branch April 15, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants