Skip to content

fix: should not rename __webpack_require__ if declared in current scope#10016

Merged
JSerFeng merged 1 commit intomainfrom
fix/compat-webpack-plugin
Apr 15, 2025
Merged

fix: should not rename __webpack_require__ if declared in current scope#10016
JSerFeng merged 1 commit intomainfrom
fix/compat-webpack-plugin

Conversation

@JSerFeng
Copy link
Contributor

Summary

If __webpack_require__ is defined in current scope, should not rename it

const __webpack_require__ = '1'

context = { __webpack_require__ }

__webpack_require__ above should not be renamed

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 14, 2025
@netlify
Copy link

netlify bot commented Apr 14, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit b298418
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67fe2998df31ea000837ddc4
😎 Deploy Preview https://deploy-preview-10016--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JSerFeng JSerFeng changed the title fix: should not rename __webpack_require__ if decl in current scope fix: should not rename __webpack_require__ if declared in current scope Apr 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 14, 2025

CodSpeed Performance Report

Merging #10016 will not alter performance

Comparing fix/compat-webpack-plugin (b298418) with main (73b9679)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@JSerFeng JSerFeng force-pushed the fix/compat-webpack-plugin branch from f1fae0e to b298418 Compare April 15, 2025 09:40
@JSerFeng JSerFeng requested a review from ahabhgk April 15, 2025 10:08
@JSerFeng JSerFeng merged commit ff1c3b7 into main Apr 15, 2025
27 checks passed
@JSerFeng JSerFeng deleted the fix/compat-webpack-plugin branch April 15, 2025 11:18
@renovate renovate bot mentioned this pull request May 7, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants