Skip to content

Commit 3c5a3e0

Browse files
authored
feat!: remove deprecated getHooks method from plugins (#12738)
refactor: remove deprecated getHooks method from plugins
1 parent 5019856 commit 3c5a3e0

4 files changed

Lines changed: 3 additions & 23 deletions

File tree

packages/rspack/etc/core.api.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3038,7 +3038,6 @@ export type HotUpdateMainFilename = FilenameTemplate;
30383038

30393039
// @public (undocumented)
30403040
export const HtmlRspackPlugin: typeof HtmlRspackPluginImpl & {
3041-
getHooks: (compilation: Compilation) => HtmlRspackPluginHooks;
30423041
getCompilationHooks: (compilation: Compilation) => HtmlRspackPluginHooks;
30433042
createHtmlTagObject: (tagName: string, attributes?: Record<string, string | boolean>, innerHTML?: string) => JsHtmlPluginTag;
30443043
version: number;
@@ -6413,7 +6412,6 @@ type RewriteTo = (context: HistoryContext) => string;
64136412

64146413
// @public (undocumented)
64156414
const RsdoctorPlugin: typeof RsdoctorPluginImpl & {
6416-
getHooks: (compilation: Compilation) => RsdoctorPluginHooks;
64176415
getCompilationHooks: (compilation: Compilation) => RsdoctorPluginHooks;
64186416
};
64196417

@@ -7169,7 +7167,6 @@ enum RuntimeModuleStage {
71697167

71707168
// @public (undocumented)
71717169
export const RuntimePlugin: typeof RuntimePluginImpl & {
7172-
getHooks: (compilation: Compilation) => RuntimePluginHooks;
71737170
getCompilationHooks: (compilation: Compilation) => RuntimePluginHooks;
71747171
};
71757172

packages/rspack/src/builtin-plugin/RsdoctorPlugin.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -107,16 +107,10 @@ const compilationHooksMap: WeakMap<Compilation, RsdoctorPluginHooks> =
107107
new WeakMap();
108108

109109
const RsdoctorPlugin = RsdoctorPluginImpl as typeof RsdoctorPluginImpl & {
110-
/**
111-
* @deprecated Use `getCompilationHooks` instead.
112-
*/
113-
getHooks: (compilation: Compilation) => RsdoctorPluginHooks;
114110
getCompilationHooks: (compilation: Compilation) => RsdoctorPluginHooks;
115111
};
116112

117-
RsdoctorPlugin.getHooks = RsdoctorPlugin.getCompilationHooks = (
118-
compilation: Compilation,
119-
) => {
113+
RsdoctorPlugin.getCompilationHooks = (compilation: Compilation) => {
120114
checkCompilation(compilation);
121115

122116
let hooks = compilationHooksMap.get(compilation);

packages/rspack/src/builtin-plugin/RuntimePlugin.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,13 @@ export type RuntimePluginHooks = {
2020
};
2121

2222
const RuntimePlugin = RuntimePluginImpl as typeof RuntimePluginImpl & {
23-
/**
24-
* @deprecated Use `getCompilationHooks` instead.
25-
*/
26-
getHooks: (compilation: Compilation) => RuntimePluginHooks;
2723
getCompilationHooks: (compilation: Compilation) => RuntimePluginHooks;
2824
};
2925

3026
const compilationHooksMap: WeakMap<Compilation, RuntimePluginHooks> =
3127
new WeakMap();
3228

33-
RuntimePlugin.getHooks = RuntimePlugin.getCompilationHooks = (
34-
compilation: Compilation,
35-
) => {
29+
RuntimePlugin.getCompilationHooks = (compilation: Compilation) => {
3630
checkCompilation(compilation);
3731

3832
let hooks = compilationHooksMap.get(compilation);

packages/rspack/src/builtin-plugin/html-plugin/plugin.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -243,10 +243,6 @@ function htmlTagObjectToString(tag: {
243243
}
244244

245245
const HtmlRspackPlugin = HtmlRspackPluginImpl as typeof HtmlRspackPluginImpl & {
246-
/**
247-
* @deprecated Use `getCompilationHooks` instead.
248-
*/
249-
getHooks: (compilation: Compilation) => HtmlRspackPluginHooks;
250246
getCompilationHooks: (compilation: Compilation) => HtmlRspackPluginHooks;
251247
createHtmlTagObject: (
252248
tagName: string,
@@ -287,8 +283,7 @@ HtmlRspackPlugin.createHtmlTagObject = (
287283
};
288284
};
289285

290-
HtmlRspackPlugin.getHooks = HtmlRspackPlugin.getCompilationHooks =
291-
getPluginHooks;
286+
HtmlRspackPlugin.getCompilationHooks = getPluginHooks;
292287
HtmlRspackPlugin.version = 5;
293288

294289
export { HtmlRspackPlugin };

0 commit comments

Comments
 (0)