Skip to content

feat!: remove deprecated getHooks method from plugins#12738

Merged
chenjiahan merged 1 commit intov2from
refactor/remove-get-hooks-method
Jan 15, 2026
Merged

feat!: remove deprecated getHooks method from plugins#12738
chenjiahan merged 1 commit intov2from
refactor/remove-get-hooks-method

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

@LingyuCoder LingyuCoder commented Jan 15, 2026

Summary

This PR removes the deprecated getHooks method from HtmlRspackPlugin, RsdoctorPlugin, and RuntimePlugin. These plugins now only expose getCompilationHooks method, which is the recommended way to access compilation hooks. This change simplifies the API and removes deprecated functionality that was marked for removal.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from hardfist as a code owner January 15, 2026 03:42
@netlify
Copy link
Copy Markdown

netlify bot commented Jan 15, 2026 •
edited
Loading

✅ Deploy Preview for rspack-v2 canceled.

Name Link
🔨 Latest commit 30952c2
🔍 Latest deploy log https://app.netlify.com/projects/rspack-v2/deploys/696862121b8ce30008547a3b

@github-actions github-actions bot added release: refactor team The issue/pr is created by the member of Rspack. labels Jan 15, 2026
@LingyuCoder LingyuCoder changed the title refactor: remove deprecated getHooks method from plugins feat!: remove deprecated getHooks method from plugins Jan 15, 2026
@github-actions github-actions bot added release: feature release: feature related release(mr only) and removed release: refactor labels Jan 15, 2026
@LingyuCoder LingyuCoder enabled auto-merge (squash) January 15, 2026 03:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 15, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 3 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -8.0 B (-0.0%)
react-1k 825.4 KB 0
react-5k 2.7 MB +1.0 B (0.0%)
rome 986.0 KB +1.7 KB (0.2%)
ui-components 2.1 MB 0
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: d9915de43e | PR: #12735

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB -8.0 B (-0.0%)
📄 JavaScript 5.7 MB 5.7 MB -8.0 B (-0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-10k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: d9915de43e | PR: #12735

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB +1.0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB +1.0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: d9915de43e | PR: #12735

Metric Current Baseline Change
📊 Total Size 986.0 KB 984.3 KB +1.7 KB (0.2%)
📄 JavaScript 986.0 KB 984.3 KB +1.7 KB (0.2%)
🎨 CSS 0 B 0 B 0
🌐 HTML 0 B 0 B 0
📁 Other Assets 0 B 0 B 0

📦 Download Diff Report: rome Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 15, 2026

📦 Binary Size-limit

Comparing 30952c2 to refactor: move pass into separate folder and driven by run_passes (#12735) by hardfist

🎉 Size decreased by 451.25KB from 48.01MB to 47.57MB (⬇️0.92%)

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing refactor/remove-get-hooks-method (30952c2) with v2 (edc0379)

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark1

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@chenjiahan chenjiahan disabled auto-merge January 15, 2026 05:14
@chenjiahan chenjiahan merged commit 3c5a3e0 into v2 Jan 15, 2026
58 checks passed
@chenjiahan chenjiahan deleted the refactor/remove-get-hooks-method branch January 15, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

@hardfist hardfist Awaiting requested review from hardfist hardfist is a code owner

Assignees

No one assigned

Labels

release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LingyuCoder @chenjiahan