@typescript-eslint/no-dynamic-delete by ScriptedAlchemy · Pull Request #481 · web-infra-dev/rslint

ScriptedAlchemy · 2026-02-20T21:24:34Z

Summary: Port @typescript-eslint/no-dynamic-delete from ScriptedAlchemy#13.

Summary of Changes

Hello @ScriptedAlchemy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the @typescript-eslint/no-dynamic-delete rule, ported from ScriptedAlchemy/rslint#13, to enhance code quality and prevent potential runtime errors in TypeScript projects. The rule specifically targets the misuse of the delete operator with non-literal computed property keys, promoting safer and more predictable object manipulation.

Highlights

New Rule Implementation: Implemented the @typescript-eslint/no-dynamic-delete rule, which disallows the delete operator on dynamically computed property keys unless the key is a literal. This helps prevent unexpected runtime behavior and improves code safety.
Rule Integration: The new rule has been integrated into the rslint configuration, including its import, registration, and default setting to off in rslint.json.
Comprehensive Testing: Dedicated unit tests and snapshot tests have been added to validate the rule's behavior, covering various valid and invalid use cases for dynamic delete operations.
Documentation: New documentation (no_dynamic_delete.md) has been created, detailing the rule's purpose, providing examples of correct and incorrect code, and linking to the original typescript-eslint documentation.

Changelog

internal/config/config.go
- Imported the no_dynamic_delete rule package.
- Registered the NoDynamicDeleteRule with the global rule registry.
internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.go
- Added the core logic for the no-dynamic-delete rule, including functions to build rule messages and determine allowed delete arguments.
- Defined the NoDynamicDeleteRule to detect and report dynamic delete expressions on non-literal property keys.
internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.md
- Added documentation for the no-dynamic-delete rule, explaining its purpose and providing code examples.
internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete_test.go
- Added a comprehensive suite of unit tests for the no-dynamic-delete rule, covering both valid and invalid code scenarios.
packages/rslint-test-tools/rstest.config.mts
- Uncommented and enabled the test file for no-dynamic-delete in the test configuration.
packages/rslint-test-tools/tests/typescript-eslint/rules/snapshots/no-dynamic-delete.test.ts.snap
- Added snapshot test results for the no-dynamic-delete rule's invalid cases.
rslint.json
- Added @typescript-eslint/no-dynamic-delete rule to the configuration, setting its default level to off.

Activity

The @typescript-eslint/no-dynamic-delete rule has been ported from ScriptedAlchemy/rslint#13.
Tests have been updated to include coverage for the new rule.
Documentation for the new rule has been created and updated.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request ports the @typescript-eslint/no-dynamic-delete rule. The implementation is clean and follows the project's structure. The added tests are comprehensive. I've found a minor correctness issue in handling parenthesized numeric literals and also a small suggestion to improve performance by defining the rule message as a package-level variable to avoid repeated allocations.

internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.go

Copilot

Pull request overview

Ports the @typescript-eslint/no-dynamic-delete rule into this codebase (implementation + registration), and enables/extends the cross-runner test coverage to validate behavior against the TypeScript ESLint rule expectations.

Changes:

Added the no-dynamic-delete rule implementation, documentation, and Go rule-tester coverage.
Registered the rule under @typescript-eslint/no-dynamic-delete in the global TypeScript ESLint plugin registry.
Enabled and expanded the rslint-test-tools TypeScript test and added its snapshot output.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
rslint.json	Adds the new rule to the example/config ruleset (defaulted to `off`).
packages/rslint-test-tools/tests/typescript-eslint/rules/no-dynamic-delete.test.ts	Adds an additional invalid test case for dynamic delete.
packages/rslint-test-tools/tests/typescript-eslint/rules/snapshots/no-dynamic-delete.test.ts.snap	Introduces the snapshot baselines for the test suite output.
packages/rslint-test-tools/rstest.config.mts	Enables running the `no-dynamic-delete` test in the rstest suite.
internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.go	Implements the rule logic and diagnostic reporting.
internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete_test.go	Adds Go-based rule tester coverage (valid/invalid cases + locations).
internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.md	Adds rule documentation and a link to upstream docs.
internal/config/config.go	Registers `@typescript-eslint/no-dynamic-delete` in the rule registry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

cloudflare-workers-and-pages · 2026-03-03T04:07:37Z

Deploying rslint with Cloudflare Pages

Latest commit:	`c560257`
Status:	✅ Deploy successful!
Preview URL:	https://38a89728.rslint.pages.dev
Branch Preview URL:	https://codex-ts-eslint-no-dynamic-d.rslint.pages.dev

View logs

…namic-delete-51aa # Conflicts: # rslint.json

internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.go

internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.md

…namic-delete-51aa # Conflicts: # rslint.json

feat: port rule @typescript-eslint/no-dynamic-delete

0959865

gemini-code-assist bot reviewed Feb 20, 2026

View reviewed changes

internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.go Outdated Show resolved Hide resolved

internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.go Outdated Show resolved Hide resolved

ScriptedAlchemy and others added 3 commits February 22, 2026 18:15

fix: align no-dynamic-delete with upstream

54d0069

Merge branch 'main' into codex/ts-eslint-no-dynamic-delete-51aa

1d83718

fix(typescript/no-dynamic-delete): handle parenthesized negatives

f3c4798

ScriptedAlchemy marked this pull request as ready for review February 26, 2026 03:45

Copilot AI review requested due to automatic review settings February 26, 2026 03:45

ScriptedAlchemy enabled auto-merge (squash) February 26, 2026 03:45

Copilot started reviewing on behalf of ScriptedAlchemy February 26, 2026 03:45 View session

Copilot AI reviewed Feb 26, 2026

View reviewed changes

Merge branch 'main' into codex/ts-eslint-no-dynamic-delete-51aa

284044e

ScriptedAlchemy and others added 11 commits March 4, 2026 00:15

Merge branch 'main' into codex/ts-eslint-no-dynamic-delete-51aa

65aab02

Merge branch 'main' into codex/ts-eslint-no-dynamic-delete-51aa

91a02d2

Merge remote-tracking branch 'origin/main' into codex/ts-eslint-no-dy…

8c7d79e

…namic-delete-51aa # Conflicts: # rslint.json

Merge branch 'main' into codex/ts-eslint-no-dynamic-delete-51aa

817c5c8

Merge branch 'main' into codex/ts-eslint-no-dynamic-delete-51aa

e90b6bd

fix: preserve null output sentinel in rule tester

1699e32

fix: preserve null outputs in rule-tester snapshots

48e4ae2

Merge remote-tracking branch 'origin/main' into codex/ts-eslint-no-dy…

5d30d33

…namic-delete-51aa # Conflicts: # rslint.json

Merge remote-tracking branch 'origin/main' into codex/ts-eslint-no-dy…

20a9e43

…namic-delete-51aa # Conflicts: # rslint.json

Merge branch 'main' into codex/ts-eslint-no-dynamic-delete-51aa

59e8113

Merge branch 'main' into codex/ts-eslint-no-dynamic-delete-51aa

c560257

fansenze reviewed Mar 13, 2026

View reviewed changes

internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.go Show resolved Hide resolved

internal/plugins/typescript/rules/no_dynamic_delete/no_dynamic_delete.md Show resolved Hide resolved

ScriptedAlchemy and others added 3 commits March 12, 2026 20:32

docs: clarify no-dynamic-delete template literal case

fcd5a8a

Merge remote-tracking branch 'origin/main' into codex/ts-eslint-no-dy…

4368ce7

…namic-delete-51aa # Conflicts: # rslint.json

Merge branch 'main' into codex/ts-eslint-no-dynamic-delete-51aa

da4e69f

fansenze approved these changes Mar 19, 2026

View reviewed changes

ScriptedAlchemy merged commit 80d6c1e into main Mar 19, 2026
15 checks passed

ScriptedAlchemy deleted the codex/ts-eslint-no-dynamic-delete-51aa branch March 19, 2026 02:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

@typescript-eslint/no-dynamic-delete#481

@typescript-eslint/no-dynamic-delete#481
ScriptedAlchemy merged 19 commits intomainfrom
codex/ts-eslint-no-dynamic-delete-51aa

ScriptedAlchemy commented Feb 20, 2026

Uh oh!

gemini-code-assist bot commented Feb 20, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

cloudflare-workers-and-pages bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ScriptedAlchemy commented Feb 20, 2026

Uh oh!

gemini-code-assist bot commented Feb 20, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

cloudflare-workers-and-pages bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying rslint with Cloudflare Pages

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cloudflare-workers-and-pages bot commented Mar 3, 2026 •

edited

Loading