chore: small tweaks to add a few missing rules by ScriptedAlchemy · Pull Request #13 · ScriptedAlchemy/rslint

ScriptedAlchemy · 2026-02-09T21:30:57Z

Summary

This PR is the integration branch for the TypeScript ESLint porting/parity effort in rslint.

It includes:

Porting the remaining missing @typescript-eslint rules in Go.
Registering those rules in configuration.
Adding/updating Go unit tests and rule docs for the added rules.
Enabling and hardening many upstream rstest suites and snapshots.
Supporting CI/dogfooding stabilization updates (including warning-level dogfood overrides for currently noisy rules and CI timeout/format/spellcheck fixes).

Rules added on this branch (vs main)

@typescript-eslint/explicit-module-boundary-types
@typescript-eslint/max-params
@typescript-eslint/method-signature-style
@typescript-eslint/naming-convention
@typescript-eslint/no-confusing-non-null-assertion
@typescript-eslint/no-deprecated
@typescript-eslint/no-dupe-class-members
@typescript-eslint/no-dynamic-delete
@typescript-eslint/no-empty-object-type
@typescript-eslint/no-import-type-side-effects
@typescript-eslint/no-invalid-this
@typescript-eslint/no-loop-func
@typescript-eslint/no-magic-numbers
@typescript-eslint/no-redeclare
@typescript-eslint/no-restricted-imports
@typescript-eslint/no-restricted-types
@typescript-eslint/no-shadow
@typescript-eslint/no-type-alias
@typescript-eslint/no-unnecessary-condition
@typescript-eslint/no-unnecessary-parameter-property-assignment
@typescript-eslint/no-unnecessary-qualifier
@typescript-eslint/no-unnecessary-type-constraint
@typescript-eslint/no-unnecessary-type-conversion
@typescript-eslint/no-unnecessary-type-parameters
@typescript-eslint/no-unsafe-declaration-merging
@typescript-eslint/no-unsafe-function-type
@typescript-eslint/no-unused-expressions
@typescript-eslint/no-unused-private-class-members
@typescript-eslint/no-use-before-define
@typescript-eslint/no-useless-constructor
@typescript-eslint/no-wrapper-object-types
@typescript-eslint/parameter-properties
@typescript-eslint/prefer-destructuring
@typescript-eslint/prefer-enum-initializers
@typescript-eslint/prefer-find
@typescript-eslint/prefer-for-of
@typescript-eslint/prefer-function-type
@typescript-eslint/prefer-includes
@typescript-eslint/prefer-literal-enum-member
@typescript-eslint/prefer-namespace-keyword
@typescript-eslint/prefer-nullish-coalescing
@typescript-eslint/prefer-optional-chain
@typescript-eslint/prefer-regexp-exec
@typescript-eslint/prefer-string-starts-ends-with
@typescript-eslint/prefer-ts-expect-error
@typescript-eslint/sort-type-constituents
@typescript-eslint/strict-boolean-expressions
@typescript-eslint/typedef

Current status

Large portions of upstream parity suites are enabled and passing.
Remaining parity-heavy suites are being iteratively hardened where still needed.
Local dogfooding currently passes with selected noisy rules set to warning in root rslint.json.

cursor · 2026-02-09T21:30:59Z

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

changeset-bot · 2026-02-09T21:31:01Z

⚠️ No Changeset found

Latest commit: 6b9bb3f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

internal/plugins/typescript/rules/ban_tslint_comment/ban_tslint_comment.go

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

Re-enable previously skipped test scenarios and tighten rule-tester message-id matching so missing behavior is no longer masked. Update the affected TypeScript rules to satisfy those restored cases and keep CLI format checks strict without disabling rules. Co-authored-by: Cursor <cursoragent@cursor.com>

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

Move API language-option matching/merging onto shared config helpers, harden no-deprecated matching away from regex-heavy import detection, and restore out-of-scope files to main-equivalent content to reduce review noise. Co-authored-by: Cursor <cursoragent@cursor.com>

Add stronger no-deprecated import/allow-path coverage and reason checks, enforce output assertions in the rule-tester autofix path, and include the newly enabled strict-void-return/no-useless-default-assignment suite wiring. Co-authored-by: Cursor <cursoragent@cursor.com>

Replace the dedicated member-ordering variant suite files with new strict-void-return and no-useless-default-assignment rule implementations and parity test wiring so the branch tracks the active rule port scope. Co-authored-by: Cursor <cursoragent@cursor.com>

Revert low-value package and harness churn, restore deleted member-ordering variant suites, and keep the checker shim change minimal to required behavior. Also correct ban-ts-comment multiline parsing and consistent-type-assertions precedence so rule diagnostics stay parity-consistent. Co-authored-by: Cursor <cursoragent@cursor.com>

Treat Foo[] index-signature value types as reportable instead of circular and update rule tests to match the migrated upstream parity cases. Co-authored-by: Cursor <cursoragent@cursor.com>

Avoid calling node.Text on unsupported declaration-name nodes in no-deprecated so destructuring patterns no longer panic during parity runs, and make the CLI github-format test assert required diagnostics without assuming no additional annotations. Co-authored-by: Cursor <cursoragent@cursor.com>

ramicats · 2026-02-13T18:52:09Z

very small tweaks indeed!

Include all missing member-ordering and no-unused-vars parity artifacts in rstest, and resolve upstream suite aliases to canonical rule IDs so imported test files execute against the intended rslint rule. Co-authored-by: Cursor <cursoragent@cursor.com>

…overage Add autofix behavior and stronger invalid-case coverage for no-useless-default-assignment in Go tests, align JS parity expectations, and introduce missing no-loss-of-precision Go tests to close the reported coverage hole. Co-authored-by: Cursor <cursoragent@cursor.com>

Restore JS output assertions and Go coverage for no-useless-default-assignment so both parity layers validate autofix behavior. Update core diagnostic typing with optional fix metadata to align the RuleTester fix pipeline. Co-authored-by: Cursor <cursoragent@cursor.com>

Use UTF-8 byte lengths for IPC framing and align apply-fixes handling with upstream-style single-pass semantics to avoid corrupted or unstable outputs. Also add no-import-type-side-effects autofix support with matching Go test assertions to restore parity expectations. Co-authored-by: Cursor <cursoragent@cursor.com>

Improve rule parity for the newly added TypeScript rules by tightening edge-case handling in autofixes and option parsing. This keeps fixes stable across repeated passes and aligns diagnostics/output expectations with the rule test harness. Co-authored-by: Cursor <cursoragent@cursor.com>

pkasarda

LGTM!

…script-eslint-rules-b4ce # Conflicts: # internal/config/config.go # internal/plugins/typescript/rules/prefer_namespace_keyword/prefer_namespace_keyword.go # internal/plugins/typescript/rules/prefer_namespace_keyword/prefer_namespace_keyword.md # internal/plugins/typescript/rules/prefer_namespace_keyword/prefer_namespace_keyword_test.go # internal/plugins/typescript/rules/prefer_string_starts_ends_with/prefer_string_starts_ends_with.go # packages/rslint-test-tools/rstest.config.mts # packages/rslint-test-tools/tests/typescript-eslint/rules/__snapshots__/prefer-namespace-keyword.test.ts.snap # packages/rslint-test-tools/tests/typescript-eslint/rules/__snapshots__/prefer-string-starts-ends-with.test.ts.snap # packages/rslint/src/node.ts

cursoragent and others added 28 commits February 10, 2026 00:39

test: add snapshot for prefer-for-of

22c12e6

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

feat: implement no-empty-object-type rule baseline

c59140d

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

test: enable no-empty-object-type rstest

e83f53f

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: allow multi-extends empty interfaces in no-empty-object-type

0f21c7a

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: allow intersection empty object literals in no-empty-object-type

3082a36

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

test: add snapshot for no-empty-object-type

fb2636a

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: align sort-type-constituents with upstream ordering

642c383

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

test: enable method-signature-style rstest suite

0c07bdb

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: enable no-redeclare rstest suite

e24da9a

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: merge default language options in rule tester

67ba311

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

test: add parser option and redeclare merge coverage

ac0b889

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: align no-invalid-this behavior and enable rstest suite

13a7eb8

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: align no-loop-func parity and enable rstest suite

3e0d687

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: align no-use-before-define semantics and enable suite

022971a

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: align no-shadow eslint parity and enable suite

34c2c17

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: complete no-shadow typescript parity and globals handling

ad42cac

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: align no-restricted-imports with upstream semantics

c790707

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: enable and align no-unnecessary-type-conversion suite

814b235

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: enable no-unnecessary-type-arguments rstest suite

66416ec

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: enable no-magic-numbers suite with ts parity

43cd446

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

feat: implement no-unnecessary-parameter-property-assignment baseline

8272942

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: resolve parameter-property references by declaration

3231433

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

test: align no-unnecessary-parameter-property-assignment columns

48dad74

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

test: enable no-unnecessary-parameter-property-assignment rstest

583608f

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: account for prior mutations in parameter-property assignment rule

e2bab7d

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: enable typedef suite with upstream option parity

13e291b

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: ignore deferred class expressions in eager mutation scan

3ea5b19

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

test: add snapshot for no-unnecessary-parameter-property-assignment

7704dbc

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

ScriptedAlchemy commented Feb 13, 2026

View reviewed changes

internal/plugins/typescript/rules/ban_tslint_comment/ban_tslint_comment.go Show resolved Hide resolved

cursoragent and others added 12 commits February 13, 2026 05:23

fix: align config and API file matching semantics

b9cf35a

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: add member-ordering alias default semantics

3b65c1d

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: support tsconfig globs and safe tslint comment fixes

d64ecf8

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: satisfy spell-check in loader imports

f679e0d

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

test: normalize loader path assertions for windows

87d6211

Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>

fix: align consistent-indexed-object-style circular parity

90e53ae

Treat Foo[] index-signature value types as reportable instead of circular and update rule tests to match the migrated upstream parity cases. Co-authored-by: Cursor <cursoragent@cursor.com>

ScriptedAlchemy and others added 3 commits February 13, 2026 13:21

Repository owner deleted a comment from NiHaiden Feb 13, 2026

Repository owner deleted a comment from tokiory Feb 14, 2026

ScriptedAlchemy changed the base branch from cursor/typescript-eslint-rules-port-3ef1 to main February 14, 2026 08:49

pkasarda approved these changes Feb 17, 2026

View reviewed changes

This was referenced Feb 20, 2026

@typescript-eslint/max-params web-infra-dev/rslint#480

Open

@typescript-eslint/no-dynamic-delete web-infra-dev/rslint#481

Merged

This was referenced Feb 20, 2026

@typescript-eslint/prefer-regexp-exec web-infra-dev/rslint#482

Merged

@typescript-eslint/prefer-includes web-infra-dev/rslint#483

Merged

@typescript-eslint/prefer-ts-expect-error web-infra-dev/rslint#484

Merged

Merge branch 'main' into cursor/remaining-typescript-eslint-rules-b4ce

6b9bb3f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: small tweaks to add a few missing rules#13

chore: small tweaks to add a few missing rules#13
ScriptedAlchemy wants to merge 315 commits intomainfrom
cursor/remaining-typescript-eslint-rules-b4ce

ScriptedAlchemy commented Feb 9, 2026 •

edited

Loading

Uh oh!

cursor bot commented Feb 9, 2026

Uh oh!

changeset-bot bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

ramicats commented Feb 13, 2026

Uh oh!

pkasarda left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ScriptedAlchemy commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Rules added on this branch (vs main)

Current status

Uh oh!

cursor bot commented Feb 9, 2026

Uh oh!

changeset-bot bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

Uh oh!

ramicats commented Feb 13, 2026

Uh oh!

pkasarda left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ScriptedAlchemy commented Feb 9, 2026 •

edited

Loading

changeset-bot bot commented Feb 9, 2026 •

edited

Loading