Conversation
✅ Deploy Preview for rslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes URL generation for ESLint plugin rules by adding proper handling for different rule sources. Previously, the code assumed all rules belonged to @typescript-eslint, but now it correctly generates URLs for both @typescript-eslint and eslint-plugin-import rules.
Key Changes
- Added a
getRuleUrlfunction that generates appropriate URLs based on the rule's group - Updated the rule link to use the new URL generation function
- Minor CSS class adjustment removing
items-startfrom a button
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
hardfist
approved these changes
Aug 17, 2025
ScriptedAlchemy
pushed a commit
to ScriptedAlchemy/rslint
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the way rule documentation links are generated and used in the
RuleStatescomponent, making the code more maintainable and extensible. The main focus is on centralizing the logic for building rule URLs and ensuring the correct links are used throughout the UI.Rule documentation link improvements:
getRuleUrlfunction to generate rule documentation URLs based on the rule's group, supporting both@typescript-eslint/eslint-pluginandeslint-plugin-importrules.getRuleUrlfunction, ensuring the correct URL is opened for each rule.UI consistency: