Conversation
✅ Deploy Preview for rslint canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the rslint language server implementation to align with the TypeScript-Go LSP architecture. It modernizes the LSP server structure and improves protocol compliance.
Key Changes
- Restructures the LSP server implementation to use a handler-based architecture with proper error handling and cancellation support
- Replaces jsonrpc2 dependency with native LSP protocol implementation from typescript-go
- Implements proper LSP initialization flow with position encoding negotiation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/lsp/service.go | Updates handler method signatures to use typed parameters and implements new diagnostic response format |
| internal/lsp/server.go | Complete rewrite implementing modern LSP server architecture with proper request/response handling |
| cmd/rslint/main.go | Adds command line argument passing to LSP mode |
| cmd/rslint/lsp.go | Refactors LSP initialization to use new server architecture with proper OS-specific typing cache setup |
68c6781 to
de632cc
Compare
ScriptedAlchemy
pushed a commit
that referenced
this pull request
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
align rslint lsp implementation with tsgo lsp
the previous implementation has a fundamental flaw that jsonrpc2 use
encoding/jsonwhile tsgo use go-json-experimentwhich has subtle difference behavior for same message which cause edge bugs