Conversation
✅ Deploy Preview for rslint canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the LSP (Language Server Protocol) implementation by splitting server and service logic into separate files. The main purpose is to improve code organization and maintainability by separating concerns between server infrastructure and service-specific functionality.
Key changes:
- Moved all LSP service handler methods from
server.goto a newservice.gofile - Removed unnecessary imports from
server.gothat were only used by the moved service logic - Maintained the same functionality while improving code organization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/lsp/service.go | New file containing all LSP service handler methods and helper functions moved from server.go |
| internal/lsp/server.go | Cleaned up by removing service handler methods and their associated imports, keeping only core server infrastructure |
ScriptedAlchemy
pushed a commit
that referenced
this pull request
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split service logic so make it easier to refactor server logic