Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new TypeScript project management shim to the rslint codebase, integrating the project package from the typescript-go library. The changes enable the LSP server to manage TypeScript projects more effectively by providing access to project services and related functionality.
Key Changes:
- Added project shim generation to the shim generation tool
- Created a new project shim package with comprehensive TypeScript project management APIs
- Integrated the project service into the LSP server structure
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/gen_shims/main.go | Added "project" to the list of packages to generate shims for |
| shim/project/shim.go | Generated shim file exposing project management APIs from typescript-go |
| shim/project/go.mod | Go module definition for the project shim package |
| internal/lsp/service.go | Created empty LSP service package file |
| go.mod | Added project shim module to dependencies and replace directives |
| cmd/rslint/lsp.go | Integrated project service into LSP server structure |
Amour1688
approved these changes
Aug 12, 2025
ScriptedAlchemy
pushed a commit
that referenced
this pull request
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the current ls implementation is too native to handle large scale project, align with typescript ls implementation and use projectService for implementation