Conversation
hardfist
reviewed
Aug 6, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the VS Code extension to support resolving the Rslint binary path from the user's environment, implementing a priority-based resolution strategy. The changes introduce improved logging infrastructure and a more robust architecture for managing multiple workspace instances.
- Implements a multi-tiered binary resolution strategy (user settings → node_modules → PnP → built-in fallback)
- Adds comprehensive logging with separate channels for extension and workspace events
- Refactors the architecture from a single client to workspace-based instances
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
src/utils.ts |
Adds utility functions for file existence checking and platform detection |
src/main.ts |
New entry point that delegates to the Extension class |
src/logger.ts |
Comprehensive logging infrastructure with configurable log levels |
src/extension.ts |
Removes old monolithic extension code |
src/Rslint.ts |
New workspace-specific Rslint client manager with binary resolution logic |
src/Extension.ts |
New main extension class managing multiple workspace instances |
scripts/build.js |
Updates build entry point from extension.ts to main.ts |
package.json |
Updates main entry point reference |
.vscode/settings.template.json |
Adds TypeScript SDK configuration |
hardfist
approved these changes
Aug 7, 2025
ScriptedAlchemy
pushed a commit
that referenced
this pull request
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rslint (workspace)andRslint (extension)channel