feat(css): support css asset in bundle mode and esm/cjs#573
Merged
Conversation
6e67b32 to
00c9732
Compare
6 tasks
CodSpeed Performance ReportMerging #573 will not alter performanceComparing Summary
|
fi3ework
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dataUriLimit: 0as defaultbackground: url(./assets/logo.svg)if user want to keep asset import statement as lib (middle-level artifacts), user should turn on
"publicPath": "auto"to keep relative import of assetthis is not supported in js asset now(only in css asset), so after js asset support, I'll set
assetPrefix: 'auto'as default valueI'll do js asset part in web-infra-dev/rspack#8748, remove
publicPath: autoruntime code and keep import statementwhy
publicPath: autoshould be default value?format: 'umd'orformat: 'mf'to support, so users should rarely manully configure publicPathRelated links
#570