feat!: use 'commonjs-import' as CJS external type by default#438
Merged
feat!: use 'commonjs-import' as CJS external type by default#438
Conversation
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #438 will degrade performances by 10.65%Comparing Summary
Benchmarks breakdown
|
Member
Author
|
Done.
|
159f492 to
2c6fbf3
Compare
Timeless0911
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's hard to cover all cases of whether it's under node
13.2.0without calling Browserslist API. Since Node 13.2 has reach EOL for years (https://endoflife.date/nodejs). I think it's fine to setcommonjs-importas the default external type for Node.js and demonstrate the differences between the externals type on library build scenario next.Also bump Rsbuild to
~1.1.4Related Links
Checklist