Skip to content

fix: checkMFPlugin function support array plugins#419

Merged
Timeless0911 merged 2 commits intomainfrom
fix/rsbuild-plugins
Nov 14, 2024
Merged

fix: checkMFPlugin function support array plugins#419
Timeless0911 merged 2 commits intomainfrom
fix/rsbuild-plugins

Conversation

@2heal1
Copy link
Copy Markdown
Member

@2heal1 2heal1 commented Nov 13, 2024

Summary

plugins may pass array type like this:

{
      format: 'mf',
      plugins: [
        [
          { name: 'rsbuild:module-federation-enhanced', setup: () => {} },
          { name: 'plugin-foo', setup: () => {} },
        ],
      ],
}

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chenjiahan chenjiahan requested a review from nyqykk November 13, 2024 08:40
nyqykk
nyqykk reviewed Nov 13, 2024
View reviewed changes
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Nov 13, 2024

CodSpeed Performance Report

Merging #419 will not alter performance

Comparing fix/rsbuild-plugins (f813069) with main (dacb1d2)

Summary

✅ 5 untouched benchmarks

@Timeless0911 Timeless0911 merged commit d3c1c16 into main Nov 14, 2024
@Timeless0911 Timeless0911 deleted the fix/rsbuild-plugins branch November 14, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nyqykk nyqykk nyqykk left review comments

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees

No one assigned

Labels

change: fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@2heal1 @Timeless0911 @nyqykk