feat(create-rslib): add react template and tools(storybook/vitest) by fi3ework · Pull Request #326 · web-infra-dev/rslib

fi3ework · 2024-10-23T16:01:12Z

Summary

Programmatically generate templates

The generated template path is in pattern of [${template}]-[${(tools ? Object.keys(tools) : []).sort()}]-${lang}.
Add new tools step (support vitest and storybook for now), vitest is applicable for all templates and storybook is applicable for UI related template (react).

Add React template

React (and other UI frameworks) is applicable with tool Storybook.

Templates tweak

Adding typescript dependency and dts: true for JS projects: Emitting dts for JS templates. It's acceptable to write non-TS project sometimes, but dts is recommended to emit and enable partial type check when needed.

TODO

As the templates getting more complex, I wonder does the tools step merge into create-rstack?
Is adding TS stuff to JS project also applicable for Rsbuild JS projects?

Checklist

Tests updated (or not required).
Documentation updated (or not required).

netlify · 2024-10-23T16:02:24Z

✅ Deploy Preview for rslib ready!

Name	Link
🔨 Latest commit	`71530f9`
🔍 Latest deploy log	https://app.netlify.com/sites/rslib/deploys/671f89fec734560007a48a3f
😎 Deploy Preview	https://deploy-preview-326--rslib.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codspeed-hq · 2024-10-23T16:09:50Z

CodSpeed Performance Report

Merging #326 will not alter performance

_{Comparing react-template (d2443db) with main (f017d90)}

Summary

✅ 5 untouched benchmarks

.nvmrc

packages/create-rslib/fragments/base/react-js/rslib.config.mjs

packages/create-rslib/fragments/base/react-ts/rslib.config.ts

packages/create-rslib/fragments/tools/vitest-node-ts/package.json

packages/create-rslib/fragments/base/react-ts/rslib.config.ts

chenjiahan · 2024-10-29T11:09:46Z

Is adding TS stuff to JS project also applicable for Rsbuild JS projects?

I think developers of JS projects may not want to use TypeScript

chenjiahan · 2024-10-29T11:14:18Z

I wonder does the tools step merge into create-rstack?

It depends on the contents of tools. For example, Biome and ESLint templates are suitable for all projects (Rspack, Rsbuild, Rslib...), so we keep them in the create-rstack repo.

For Storybook or Vitest, the config file might be different for Rspack, Rsbuild or Rslib.

Timeless0911 · 2024-10-29T11:25:23Z

The PR title can be more precise🥹

fi3ework · 2024-10-29T16:09:04Z

I think developers of JS projects may not want to use TypeScript

I was wrong, I forget TS can't only check part of the file. Will remove TS check.

fi3ework · 2024-10-30T03:08:38Z

The generated template files are numerous and may continue to grow. We can generate these template files during the create-rslib publish or postinstall stages. However, we need more testing to ensure this approach works. For now, we will keep the template files in the repository to assist with code reviews.

fi3ework marked this pull request as draft October 23, 2024 16:01

github-actions bot added the change: feat label Oct 23, 2024

fi3ework force-pushed the react-template branch from 2fbe0bd to 27435cf Compare October 23, 2024 16:12