perf(deps): replace fast-glob with tinyglobby#307
Merged
Conversation
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CodSpeed Performance ReportMerging #307 will improve performances by 68.85%Comparing Summary
Benchmarks breakdown
|
Contributor
|
We also prebundled |
Timeless0911
approved these changes
Oct 18, 2024
fi3ework
reviewed
Oct 18, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tinyglobby is a fast and minimal alternative to globby and fast-glob, it is used by tsup, Vite and Nuxt.
tinyglobbyis now independenciesof@rslib/corebecausersbuild-plugin-dtsalso depends on it. If we prebundle it, there will be two copies of the code.absolute: truebecausefast-globandtinyglobbyuse different relative formats,fast-globwill return./path/to/file.js,tinyglobbywill returnpath/to/file.js. Also the absolute path is more friendly to the NodefsAPIs.This PR should reduce 15 sub-dependencies of Rslib:
Related Links
https://github.com/SuperchupuDev/tinyglobby?tab=readme-ov-file#api
Checklist