feat: support css in bundless mode by SoonIter · Pull Request #206 · web-infra-dev/rslib

SoonIter · 2024-09-14T09:41:47Z

Summary

closes #182

support css files in bundless mode
- add cssConfig.ts and composeCssConfig
- replace CssExtractPlugin.loader with LibCssExtractLoader which is forked
- remove CssExtractPlugin
- add RemoveCssExtractAssetPlugin
- support redirect.style
migrate the css test from modernjs module
- css
- less
- sass
- tailwind
- css modules
- postcss
- lightningcss
add examples & e2e & benchmark for bundle false component

Checklist

Tests updated (or not required).
Documentation updated (or not required).

netlify · 2024-09-14T09:42:02Z

✅ Deploy Preview for rslib ready!

Name	Link
🔨 Latest commit	`ee0ecf6`
🔍 Latest deploy log	https://app.netlify.com/sites/rslib/deploys/6706666d45e9610008ed0e56
😎 Deploy Preview	https://deploy-preview-206--rslib.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codspeed-hq · 2024-09-30T09:59:52Z

CodSpeed Performance Report

Merging #206 will not alter performance

_{Comparing SoonIter:css-support (8ce1cea) with main (146b38e)}

Summary

✅ 1 untouched benchmarks

🆕 2 new benchmarks
⁉️ 1 (👁 1) dropped benchmarks

Benchmarks breakdown

	Benchmark	`main`	`SoonIter:css-support`	Change
👁	`examples/react-component`	112 ms	N/A	N/A
🆕	`examples/react-component-bundle`	N/A	163.3 ms	N/A
🆕	`examples/react-component-bundle-false`	N/A	194.5 ms	N/A

biome.json

examples/react-component/tsconfig.json

packages/core/src/css/LibCssExtractLoader.ts

packages/core/src/css/cssConfig.ts

packages/core/src/types/config/index.ts

Timeless0911 · 2024-10-08T09:43:22Z

css tests like less should be added more

packages/core/package.json

packages/core/rslib.config.ts

packages/core/src/css/LibCssExtractLoader.ts

packages/core/src/css/cssConfig.ts

Timeless0911 · 2024-10-09T06:06:02Z

Add some tests about

postcss
tailwindcss
style inject

And has the redirect.css behaviour been tested?

fi3ework · 2024-10-09T06:32:32Z

By the way, it's better to add the document alongside. @Timeless0911 What about adding the basic doc outline today?

Timeless0911 · 2024-10-09T06:48:01Z

By the way, it's better to add the document alongside. @Timeless0911 What about adding the basic doc outline today?

I'll make a draft later today.

packages/core/rslib.config.ts

packages/core/src/config.ts

biome.json

Timeless0911 · 2024-10-09T10:06:40Z

https://github.com/web-infra-dev/rslib/blob/main/tests/integration/banner-footer/rslib.config.ts#L54

we should remember to add banner and footer tests about bundleless css.

SoonIter · 2024-10-10T03:28:28Z

we should remember to add banner and footer tests about bundleless css.
Currently, we do not support banner.css

this.emitFile in loader is not handled by rspack.BannerPlugin

the files are in the chunks.auxiliaryFiles not chunks.files

https://github.com/webpack/webpack/blob/65bce6826b85a48add3371d76ba16a9933326058/lib/BannerPlugin.js#L105

Maybe we can support it by adjusting bannerPlugin in the future, this is a TODO

Timeless0911 · 2024-10-10T03:31:21Z

this.emitFile in loader is not handled by rspack.BannerPlugin

the files are in the chunks.auxiliaryFiles not chunks.files

webpack/webpack@65bce68/lib/BannerPlugin.js#L105

Maybe we can support it by adjusting bannerPlugin in the future, this is a TODO

Open an issue and we can track it in the future.

fi3ework · 2024-10-10T10:56:00Z

Generally LGTM, some bug has been tracked, we could fix afterwards. cc @Timeless0911

Timeless0911 · 2024-10-10T11:27:07Z

TODO:

asset in CSS
banner and footer in CSS

github-actions bot added the change: feat label Sep 14, 2024

SoonIter force-pushed the css-support branch 2 times, most recently from 238dfd3 to 641a374 Compare September 24, 2024 03:57

SoonIter force-pushed the css-support branch 3 times, most recently from 068ae3c to f54b6ff Compare September 30, 2024 07:42

SoonIter force-pushed the css-support branch from 4d4eaf2 to eaafd58 Compare October 8, 2024 07:51

SoonIter commented Oct 8, 2024

View reviewed changes

biome.json Show resolved Hide resolved

SoonIter changed the title ~~feat: support css~~ feat: support css in bundless mode Oct 8, 2024

SoonIter marked this pull request as ready for review October 8, 2024 09:02

SoonIter requested review from Timeless0911 and fi3ework October 8, 2024 09:05

Timeless0911 reviewed Oct 8, 2024

View reviewed changes

examples/react-component/tsconfig.json Show resolved Hide resolved

packages/core/src/css/LibCssExtractLoader.ts Show resolved Hide resolved

packages/core/src/css/cssConfig.ts Show resolved Hide resolved

packages/core/src/types/config/index.ts Show resolved Hide resolved

SoonIter added 8 commits October 8, 2024 20:29

chore: update the test suite name

c108760

chore: reabse

0f56dbe

chore: add new bench suite

f22f9fd

test: add e2e test

3232aa6

chore: polish

a4384ac

chore: adopt suggestions

aad6617

chore: add css-modules and less test cases

b281570

chore: update lock

2dbd9b6

SoonIter force-pushed the css-support branch from 4855b7a to 2dbd9b6 Compare October 8, 2024 12:34

fi3ework reviewed Oct 8, 2024

View reviewed changes

SoonIter added 4 commits October 8, 2024 20:46

chore: use require shim

cbeff88

chore: adopt suggestions

63d4038

chore: add resourceQuery

2d13902

chore: rename LibCssExtractLoader -> libCssExtractLoader

773e52c

chore: rename LibCssExtractLoader -> libCssExtractLoader

ba75641

fi3ework reviewed Oct 9, 2024

View reviewed changes

packages/core/rslib.config.ts Outdated Show resolved Hide resolved

packages/core/src/config.ts Outdated Show resolved Hide resolved

biome.json Show resolved Hide resolved

SoonIter added 2 commits October 9, 2024 17:25

chore: rename RSLIB_CSS_ENTRY_FLAG

d80ec52

chore: remove banner

890c6fa

test: add tailwind postcss lightningcss

ee0ecf6

test: add redirect-style-false style-inject

50440a0

SoonIter mentioned this pull request Oct 10, 2024

[Feature]: support banner.css in bundle: false #265

Closed

SoonIter added 3 commits October 10, 2024 15:07

chore(infra): vscode settings for prettier

caf7768

test: small fix

2670c54

Merge branch 'main' into css-support

8ce1cea

SoonIter requested review from Timeless0911 and fi3ework October 10, 2024 09:50

fi3ework approved these changes Oct 10, 2024

View reviewed changes

SoonIter merged commit 1e68158 into web-infra-dev:main Oct 10, 2024

SoonIter deleted the css-support branch October 10, 2024 11:21

Uh oh!

Conversation

SoonIter commented Sep 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related Links

Checklist

Uh oh!

netlify bot commented Sep 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rslib ready!

Uh oh!

codspeed-hq bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #206 will not alter performance

Summary

Benchmarks breakdown

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Timeless0911 commented Oct 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Timeless0911 commented Oct 9, 2024

Uh oh!

fi3ework commented Oct 9, 2024

Uh oh!

Timeless0911 commented Oct 9, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Timeless0911 commented Oct 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SoonIter commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Timeless0911 commented Oct 10, 2024

Uh oh!

fi3ework commented Oct 10, 2024

Uh oh!

Timeless0911 commented Oct 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SoonIter commented Sep 14, 2024 •

edited

Loading

netlify bot commented Sep 14, 2024 •

edited

Loading

codspeed-hq bot commented Sep 30, 2024 •

edited

Loading

Timeless0911 commented Oct 9, 2024 •

edited

Loading

SoonIter commented Oct 10, 2024 •

edited

Loading