fix: changeDevtoolModuleFilename not work problem#1402
Merged
Conversation
✅ Deploy Preview for rsdoctor ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the changeDevtoolModuleFilename configuration was not being applied correctly. The fix includes:
- Updating rspack dependencies from v1.4.11 to v1.6.1
- Adding fallback fields (
moduleIdentifierandmoduleName) to handle differences in rspack's stats API - Correcting the
devtoolFallbackModuleFilenameTemplateto be a function - Moving the
changeDevtoolModuleFilenamecall outside the compilation hook to ensure it runs once during compiler setup
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Updates rspack dependencies from v1.4.11 to v1.6.1 and removes unused packages |
| packages/types/src/plugin/baseStats.ts | Adds moduleIdentifier and moduleName fields as alternatives to support rspack stats format |
| packages/graph/src/transform/module-graph/transform.ts | Implements fallback logic to use moduleIdentifier/moduleName when identifier/name are missing |
| packages/core/src/inner-plugins/plugins/bundle.ts | Fixes changeDevtoolModuleFilename to run once during apply and corrects the fallback template to be a function |
| examples/*/package.json | Updates rspack dependencies to v1.6.1 in example projects |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fi3ework
reviewed
Nov 12, 2025
Member
fi3ework
left a comment
There was a problem hiding this comment.
could you add a more detailed description? i really didn't get what this PR resolves.
Contributor
Author
OK |
fi3ework
approved these changes
Nov 12, 2025
Merged
yifancong
added a commit
that referenced
this pull request
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This mr fix two problem:
output.changeDevtoolModuleFilename === '[absolute-resource-path]', this not work.consumer._absoluteSources = consumer._sources;.Related Links