httpgrpc/server: Update NewClient to not use WithBalancerName#254
httpgrpc/server: Update NewClient to not use WithBalancerName#254bboreham merged 1 commit intoweaveworks:masterfrom
Conversation
|
For now, this is just an update of the PR opened by @metalmatze, I'll check the compat with previous versions and mark this PR as ready for review. |
fe73ea3 to
3082d6a
Compare
|
While I think the newer minor version of gRPC should be compatible with a previous minor in the same major, the change in the sum metrics for the bytes payload is suspicious. Instead of trying to figure out whether a compatibility problem does not exist (hard to prove), I decided just to simplify the original PR and just do the minimum necessary changes that work, namely, replacing the |
bboreham
left a comment
There was a problem hiding this comment.
Code change looks fine, but can you write a commit description that stands alone, fully describes this change, and doesn't require the reader to chase down three other things to understand it.
|
|
On projects consuming this module as a library, gRPC might be set at newer versions where the deprecated #WithBalancerName has been removed already. Given that the version used by this module already offers a forward-compatible method, this commit uses that instead of the deprecated #WithBalancerName. This is a simplified version of weaveworks#240, without touching the gRPC versions. Fixes weaveworks#239 Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
3082d6a to
ba79fa2
Compare
|
PR updated. The changes are now minimal. |
|
I also just changed the GitHub PR description to match the commit message, as I'm not sure which merge strategy is used in this project. |
|
Friendly ping: would this PR be accepted in its current form? |
bboreham
left a comment
There was a problem hiding this comment.
Thanks for the reminder, LGTM.
…mmon` (#8125) Not needed after weaveworks/common#254 and weaveworks/common#262 More rationale on the issue. Fixes #8085 Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
On projects consuming this module as a library, gRPC might be set at
newer versions where the deprecated #WithBalancerName has been removed
already. Given that the version used by this module already offers a
forward-compatible method, this commit uses that instead of the
deprecated #WithBalancerName.
This is a simplified version of #240, without touching the gRPC versions.
Fixes #239
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de