Migrating from go-kit/kit/log to the slimmer go-kit/log#226
Merged
bboreham merged 1 commit intoweaveworks:masterfrom Oct 15, 2021
Merged
Migrating from go-kit/kit/log to the slimmer go-kit/log#226bboreham merged 1 commit intoweaveworks:masterfrom
bboreham merged 1 commit intoweaveworks:masterfrom
Conversation
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
bboreham
approved these changes
Oct 15, 2021
Collaborator
bboreham
left a comment
There was a problem hiding this comment.
Changes lgtm; however users should note that Level support does not interop; if they are also using go-kit/kit/log then they need to update.
Contributor
Author
|
I did this for Cortex: |
Collaborator
|
Does that work? ISTM any time you have |
dannykopping
added a commit
to dannykopping/loki
that referenced
this pull request
Oct 15, 2021
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2 tasks
slim-bean
pushed a commit
to grafana/loki
that referenced
this pull request
Oct 15, 2021
* Replacing go-kit/kit/log with go-kit/log Signed-off-by: Danny Kopping <danny.kopping@grafana.com> * Appeasing the f&^$ing linter Signed-off-by: Danny Kopping <danny.kopping@grafana.com> * Adding depguard Cleaning go mod Signed-off-by: Danny Kopping <danny.kopping@grafana.com> * Updating weaveworks after weaveworks/common#226 was merged Signed-off-by: Danny Kopping <danny.kopping@grafana.com> * Appeasing the mod checker Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-kithas spun out its logger package, which is all this library uses.