Skip to content

Various updater fixes #1170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
esimkowitz merged 2 commits into from
Oct 30, 2024
Merged

Various updater fixes #1170

esimkowitz merged 2 commits into from
Oct 30, 2024

Conversation

@esimkowitz
Copy link
Contributor

@esimkowitz esimkowitz commented Oct 30, 2024

  • Fixes updater status not showing on tabs that were previously unloaded.
  • Fixes updater status showing as error when not connected to the internet
  • Adds delay after setting installing status to avoid race condition with any window close event handlers. This may fix [Bug]: v0.9.0 - Tabs getting deleted after auto update #1167

@esimkowitz esimkowitz merged commit b3fdbbc into main Oct 30, 2024
@esimkowitz esimkowitz deleted the evan/fix-net-disconnected-updater branch October 30, 2024 21:20
xxyy2024 pushed a commit to xxyy2024/waveterm_aipy that referenced this pull request Jun 24, 2025
@esimkowitz
Various updater fixes (wavetermdev#1170)
04cdeb1 
- Fixes updater status not showing on tabs that were previously
unloaded.
- Fixes updater status showing as error when not connected to the
internet
- Adds delay after setting installing status to avoid race condition
with any window close event handlers. This may fix wavetermdev#1167
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: v0.9.0 - Tabs getting deleted after auto update

2 participants

@esimkowitz