This repository was archived by the owner on Jan 16, 2026. It is now read-only.
Update README file to use non-deprecated API in examples.#88
Merged
keep94 merged 1 commit intowavefrontHQ:masterfrom Jun 23, 2022
Merged
Update README file to use non-deprecated API in examples.#88keep94 merged 1 commit intowavefrontHQ:masterfrom
keep94 merged 1 commit intowavefrontHQ:masterfrom
Conversation
keep94
added a commit
to keep94/wavefront-sdk-go
that referenced
this pull request
Jun 16, 2022
This helps fix issue wavefrontHQ#88.
shavidissa
reviewed
Jun 16, 2022
Contributor
shavidissa
left a comment
There was a problem hiding this comment.
Had a small question! Else looks good from the content side to me :)
LGTM
oppegard
suggested changes
Jun 16, 2022
oppegard
reviewed
Jun 23, 2022
README.md
Outdated
| @@ -1,4 +1,5 @@ | |||
| # wavefront-sdk-go [![build status][ci-img]][ci] [![Go Report Card][go-report-img]][go-report] [![GoDoc][godoc-img]][godoc] | |||
| # wavefront-sdk-go | |||
| [![build status][ci-img]][ci] [![Go Report Card][go-report-img]][go-report] [![GoDoc][godoc-img]][godoc] | |||
Contributor
There was a problem hiding this comment.
This changed in d7d8613. Please be sure the changes in that commit are preserved when you rebase.
oppegard
approved these changes
Jun 23, 2022
Contributor
oppegard
left a comment
There was a problem hiding this comment.
I had a small final change, for when you rebase. Otherwise, lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.