Skip to content
This repository was archived by the owner on Jan 16, 2026. It is now read-only.

Update README file to use non-deprecated API in examples.#88

Merged
keep94 merged 1 commit intowavefrontHQ:masterfrom
keep94:23392_docs
Jun 23, 2022
Merged

Update README file to use non-deprecated API in examples.#88
keep94 merged 1 commit intowavefrontHQ:masterfrom
keep94:23392_docs

Conversation

@keep94
Copy link
Copy Markdown
Contributor

@keep94 keep94 commented Jun 16, 2022

No description provided.

@keep94 keep94 requested review from oppegard and shavidissa June 16, 2022 16:42
keep94 added a commit to keep94/wavefront-sdk-go that referenced this pull request Jun 16, 2022
Copy link
Copy Markdown
Contributor

@shavidissa shavidissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a small question! Else looks good from the content side to me :)
LGTM

README.md Outdated
@@ -1,4 +1,5 @@
# wavefront-sdk-go [![build status][ci-img]][ci] [![Go Report Card][go-report-img]][go-report] [![GoDoc][godoc-img]][godoc]
# wavefront-sdk-go
[![build status][ci-img]][ci] [![Go Report Card][go-report-img]][go-report] [![GoDoc][godoc-img]][godoc]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed in d7d8613. Please be sure the changes in that commit are preserved when you rebase.

Copy link
Copy Markdown
Contributor

@oppegard oppegard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a small final change, for when you rebase. Otherwise, lgtm.

@keep94 keep94 merged commit ffbfed2 into wavefrontHQ:master Jun 23, 2022
@keep94 keep94 deleted the 23392_docs branch June 23, 2022 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants