hide a few functions that do not need to be part of the public API#100
hide a few functions that do not need to be part of the public API#100keep94 merged 1 commit intowavefrontHQ:masterfrom LukeWinikates:hide-internal-apis
Conversation
|
@keep94 - not sure if this is exactly what you had in mind, and maybe you had your own reasons for not wanting to hide these methods right away. I figured a PR would give us some code to talk about. |
|
Luke. So sorry, I am out on vacation this week. I'll be back Friday
morning. I will have a look at your PR then. Thank you for doing this work.
…On Fri, Aug 19, 2022 at 5:23 PM Luke Winikates ***@***.***> wrote:
@keep94 <https://github.com/keep94> - not sure if this is exactly what
you had in mind, and maybe you had your own reasons for not wanting to hide
these methods right away. I figured a PR would give us some code to talk
about.
—
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANOC4V5KGYW6Q5PJXMC5D3V2AQPFANCNFSM57CJDGMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
keep94
left a comment
There was a problem hiding this comment.
Luke. Thanks for the work. This is a good start. One question, why didn't you change the HistoLine() function to histoLine()?
Before committing these changes and going to v1.0.0, we should loop in @oppegard my tech lead to see if he wants anything in the API changed before moving to v1.
That's just an oversight :) I'll fix it now
Sounds good to me. I would also like to go ahead and delete the old factory methods prior to v1. |
|
@keep94 - I hid those methods and also changed |
related to issues #89 and #98