Merged
Conversation
dropwizard-metrics/3.1/pom.xml
Outdated
| <relativePath>../../pom.xml</relativePath> | ||
| </parent> | ||
|
|
||
| <artifactId>metrics-wavefront</artifactId> |
Contributor
There was a problem hiding this comment.
dropwizard-metrics instead of metrics-wavefront? (it's odd when the package is com.wavefront.metrics-wavefront with two wavefronts)
oppegard
pushed a commit
to oppegard/wavefront-proxy
that referenced
this pull request
Jun 8, 2022
Also includes MONIT-28482: Cumulative Exponential Histogram. Co-authored-by: Sumit Deo <deosu@vmware.com>
laullon
added a commit
that referenced
this pull request
Jun 9, 2022
* MONIT-26423 - support OTLP Gauge metrics * MONIT-26424 - Support OTLP Cumulative Sum metrics * Move test helper out of production code * MONIT-27039 - Support OTLP Delta Sum metrics * Add integration tests for delta sums * MONIT-26428 - Support OTLP Summary metrics * Preserve existing 'quantile' attributes as '_quantile' * MONIT-28234 - Set source on OTLP metrics (#7) Signed-off-by: Sumit Deo <deosu@vmware.com> * MONIT-26425 - Support OTLP Cumulative Histograms (#8) * Handle Cumulative Histogram * Pull out OtlpProtobufPointUtils into separate test class Co-authored-by: Glenn Oppegard <goppegard@vmware.com> * Monit 26426 delta histogram (#9) * Process Delta Histogram Update OtlpGrpcMetricsHandler's constructor to create new handler for Histogram. Update OtlpProtobufPointUtils with a logic to process delta histogram. Fix OtlpHttpHandler to send additional handler for Histogram. Fix unit tests. * Fix histogram handler Update OtlpGrpcMetricsHandler's constructor to initialize histogram handler with a correct HandlerKey. * Integration test Add an integration test in OtlpMetricsTest. Add super() in the constructor of OtlpGrpcMetricsHandler. Optimize delta histogram processing in OtlpProtobufPointUtils. * Code coverage Some optimization in OtlpProtobufPointUtils. Code coverage. * Code review Miscellaneous changes as per PR review. * [MONIT-27533] Update gRPC and OpenTelemetry dependencies (#10) - Switch pom to gRPC BOM 1.41.2 - Update opentelemtry dependencies - Upgrade to latest jaeger dependency for our jaeger listener - Remove alpha BOM that imports a single constant - Add new opentelemetry-proto dependency to get exponential histograms * MONIT-27533: Remove deprecated classes. (#15) - Change class InstrumentationLibraryMetrics to ScopeMetrics. - Change class InstrumentationLibrarySpans to ScopeSpans. * [Monit-28550] Configuration change to not forward resource attributes by default (#17) * MONIT-28550: Disable forwarding Resource Attributes by default. - Make changes for both GRPC & http. * MONIT-26427: Delta + Cumulative Exponential Histogram. (#18) Also includes MONIT-28482: Cumulative Exponential Histogram. Co-authored-by: Sumit Deo <deosu@vmware.com> * Remove a TODO. * Remove TODO about reporting internal metrics for 400 errors. Co-authored-by: Peter Stone <stonepe@vmware.com> Co-authored-by: Peter Stone <thepeterstone@gmail.com> Co-authored-by: Sumit Deo <93740684+deosu@users.noreply.github.com> Co-authored-by: keep94 <keep94@gmail.com> Co-authored-by: Sumit Deo <deosu@vmware.com> Co-authored-by: Travis Keep <travisk@vmware.com> Co-authored-by: German Laullon <glaullon@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds DropWizard Metrics Reporters which use the Wavefront Proxy for the stable version of DropWizard Metrics (which only supports point tags at the Reporter level) and the latest Master of DropWizard Metrics (which supports point tags at the Reporter and Metric level)
It seems like the way JVM metrics are collected has changed quite a bit since the YammerMetrics version that the existing JsonMetricsReporter uses (For instance the VirtualMachineMetrics class no longer exists).
I have tried to implement something similar via the .includeJvmMetrics() option that can be passed to the Reporter at build time. A user could also ignore that option (it is not on by default) and add exactly whichever JVM metrics they wish to their own MetricsRegistry.